-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: ExceptionsManager: Delete updateExceptionMessage #47167
Conversation
This pull request was exported from Phabricator. Differential Revision: D64606928 |
88e3bdb
to
b0b3bb2
Compare
This pull request was exported from Phabricator. Differential Revision: D64606928 |
b0b3bb2
to
9b652ef
Compare
…acebook#47167) Summary: I couldn't find any usages of this method in javascript. Removing, so that the native code is easier to read. Changelog: [Internal] Reviewed By: javache Differential Revision: D64606928
9b652ef
to
4d8588f
Compare
…acebook#47167) Summary: I couldn't find any usages of this method in javascript. Removing, so that the native code is easier to read. Changelog: [Internal] Reviewed By: javache Differential Revision: D64606928
This pull request was exported from Phabricator. Differential Revision: D64606928 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D64606928 |
4d8588f
to
2c59f8a
Compare
This pull request was exported from Phabricator. Differential Revision: D64606928 |
Summary: Now, handleError can be called with a JSError that wraps a non-error object! Changelog: [Internal] Reviewed By: javache Differential Revision: D64706198
…peline (facebook#47165) Summary: The c++ pipeline needs a javascript interface. We could just re-use exceptions manager (for now). Changelog: [Internal] Reviewed By: javache Differential Revision: D64779068
…facebook#47166) Summary: This method wasn't used from javascript. Changelog: [Internal] Reviewed By: javache Differential Revision: D64607415
Summary: I couldn't find any usages of this method in javascript. Removing, so that the native code is easier to read. Changelog: [Internal] Reviewed By: javache Differential Revision: D64606928
2c59f8a
to
86985dc
Compare
This pull request was exported from Phabricator. Differential Revision: D64606928 |
This pull request has been merged in 4f47439. |
Summary:
I couldn't find any usages of this method in javascript.
Removing, so that the native code is easier to read.
Changelog: [Internal]
Differential Revision: D64606928