-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS): introduce RCTUIConfiguratorProtocol #47139
Open
okwasniewski
wants to merge
1
commit into
facebook:main
Choose a base branch
from
okwasniewski:feat/RCTUIConfiguratorProtocol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−42
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
packages/react-native/Libraries/AppDelegate/RCTUIConfiguratorProtocol.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
#import <UIKit/UIKit.h> | ||
#import <React/RCTConvert.h> | ||
|
||
@class RCTRootView; | ||
|
||
@protocol RCTUIConfiguratorProtocol | ||
/** | ||
* The default `RCTColorSpace` for the app. It defaults to `RCTColorSpaceSRGB`. | ||
*/ | ||
- (RCTColorSpace)defaultColorSpace; | ||
|
||
/** | ||
* This method can be used to customize the rootView that is passed to React Native. | ||
* A typical example is to override this method in the AppDelegate to change the background color. | ||
* To achieve this, add in your `AppDelegate.mm`: | ||
* ``` | ||
* - (void)customizeRootView:(RCTRootView *)rootView | ||
* { | ||
* rootView.backgroundColor = [UIColor colorWithDynamicProvider:^UIColor *(UITraitCollection *traitCollection) { | ||
* if ([traitCollection userInterfaceStyle] == UIUserInterfaceStyleDark) { | ||
* return [UIColor blackColor]; | ||
* } else { | ||
* return [UIColor whiteColor]; | ||
* } | ||
* }]; | ||
* } | ||
* ``` | ||
* | ||
* @parameter: rootView - The root view to customize. | ||
*/ | ||
- (void)customizeRootView:(RCTRootView *)rootView; | ||
|
||
/** | ||
* It creates the RootViewController. | ||
* By default, it creates a new instance of a `UIViewController`. | ||
* You can override it to provide your own initial ViewController. | ||
* | ||
* @return: an instance of `UIViewController`. | ||
*/ | ||
- (UIViewController *)createRootViewController; | ||
|
||
/** | ||
* It assigns the rootView to the rootViewController | ||
* By default, it assigns the rootView to the view property of the rootViewController | ||
* If you are not using a simple UIViewController, then there could be other methods to use to setup the rootView. | ||
* For example: UISplitViewController requires `setViewController(_:for:)` | ||
*/ | ||
- (void)setRootView:(UIView *)rootView toRootViewController:(UIViewController *)rootViewController; | ||
@end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this from
@property
, It was read-only anyways so I don't think it needs to be a property