-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve text line height calculation to properly align text on iOS #46884
Open
ArekChr
wants to merge
13
commits into
facebook:main
Choose a base branch
from
ArekChr:improve-lineheight-calc-ios
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f998a9a - Browse repository at this point
Copy the full SHA f998a9aView commit details
Commits on Oct 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8168cf0 - Browse repository at this point
Copy the full SHA 8168cf0View commit details -
add safeguards to prevent out-of-bounds crash when accessing text att…
…ributes in calculateDrawingPoint.
Configuration menu - View commit details
-
Copy full SHA for 164bf0c - Browse repository at this point
Copy the full SHA 164bf0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f79a614 - Browse repository at this point
Copy the full SHA f79a614View commit details -
Configuration menu - View commit details
-
Copy full SHA for b044af9 - Browse repository at this point
Copy the full SHA b044af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4844731 - Browse repository at this point
Copy the full SHA 4844731View commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 76faa56 - Browse repository at this point
Copy the full SHA 76faa56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e5ed70 - Browse repository at this point
Copy the full SHA 9e5ed70View commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 09118be - Browse repository at this point
Copy the full SHA 09118beView commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 193d804 - Browse repository at this point
Copy the full SHA 193d804View commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a41f8c8 - Browse repository at this point
Copy the full SHA a41f8c8View commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ec676c - Browse repository at this point
Copy the full SHA 2ec676cView commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 848e4b2 - Browse repository at this point
Copy the full SHA 848e4b2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.