Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete CoreFeatures class #45626

Closed
wants to merge 3 commits into from
Closed

Delete CoreFeatures class #45626

wants to merge 3 commits into from

Commits on Oct 25, 2024

  1. Migrate enableCppPropsIteratorSetter to ReactNativeFeatureFlags 

    Summary:
Migrate enableCppPropsIteratorSetter to ReactNativeFeatureFlags

changelog: [internal] internal

Differential Revision: D60022936
    @mdvacca
    mdvacca committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6dd1433 View commit details
    Browse the repository at this point in the history

  2. Delete CoreFeatures::excludeYogaFromRawProps 

    Summary:
I'm deleting CoreFeatures::excludeYogaFromRawProps in favor of ReactNativeFeatureFlags::excludeYogaFromRawProps();

changelog: [internal] internal

Differential Revision: D60124448
    @mdvacca
    mdvacca committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    57f6132 View commit details
    Browse the repository at this point in the history

  3. Delete CoreFeatures class (facebook#45626) 

    Summary:
Pull Request resolved: facebook#45626

I'm deleting CoreFeatures class and all its imports because it was fully replaced by ReactNativeFeatureFlags

changelog: [changed][c++] Delete CoreFeatures class in favor of ReactNativeFeatureFlags

Reviewed By: rubennorte

Differential Revision: D60137380
    @mdvacca
    mdvacca committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    37c019e View commit details
    Browse the repository at this point in the history