Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental_boxShadow from Android base view config #45529

Closed
wants to merge 1 commit into from
Closed

Remove experimental_boxShadow from Android base view config #45529

wants to merge 1 commit into from

Commits on Jul 18, 2024

  1. Remove experimental_boxShadow from Android base view config 

    Summary:
`experimental_boxShadow` is not yet part of Android view managers, and when we enable it, we are likely to do a view manager at a time before moving to BaseViewManager.

This causes user-visible errors when viewconfig validation is turned on, since we have a static view config, but not yet a native view config.

This removes the static viewconfig for Android until we start adding setters to view manager.

It is kept in `ReactNativeStyleAttributes` (which I think can have members not in the native view-config, since it has component specific props like tintColor), and iOS base viewconfig. On Fabric iOS, this is part of BaseViewProps, and handled by RCTView, but it looks like the prop (and also `experimental_filter`, `experimental_mixBlendMode`) do not have entries in iOS RCTViewManager, which is fixed in next diff in the stack.

Differential Revision: D59939866
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9b29bec View commit details
    Browse the repository at this point in the history