Skip to content

Commit

Permalink
bump Folly to 2024.10.14.00 (#47033)
Browse files Browse the repository at this point in the history
Summary:

Lastest Folly has updates to fix build errors with LLVM 19 which is also llikely needed for NDK 27

- facebook/folly@bf46c8a


Changelog:
[Android][Updated] - Bump Folly to 2024.10.14.00

Differential Revision: D64372125
  • Loading branch information
alanleedev authored and facebook-github-bot committed Oct 16, 2024
1 parent 9627060 commit e2bb08c
Show file tree
Hide file tree
Showing 6 changed files with 100 additions and 100 deletions.
2 changes: 1 addition & 1 deletion packages/react-native/React/third-party.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
// LICENSE file in the root directory of this source tree.
//

HEADER_SEARCH_PATHS = $(SRCROOT)/../third-party/boost_1_83_0 $(SRCROOT)/../third-party/folly-2024.01.01.00 $(SRCROOT)/../third-party/glog-0.3.5/src
HEADER_SEARCH_PATHS = $(SRCROOT)/../third-party/boost_1_83_0 $(SRCROOT)/../third-party/folly-2024.10.14.00 $(SRCROOT)/../third-party/glog-0.3.5/src
OTHER_CFLAGS = -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_HAVE_CLOCK_GETTIME=1
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,8 @@ SET(folly_FLAGS
SET(folly_runtime_SRC
folly/Conv.cpp
folly/Demangle.cpp
folly/dynamic.cpp
folly/FileUtil.cpp
folly/Format.cpp
folly/json_pointer.cpp
folly/json.cpp
folly/ScopeGuard.cpp
folly/SharedMutex.cpp
folly/String.cpp
Expand All @@ -42,6 +39,9 @@ SET(folly_runtime_SRC
folly/detail/SplitStringSimd.cpp
folly/detail/UniqueInstance.cpp
folly/hash/SpookyHashV2.cpp
folly/json/dynamic.cpp
folly/json/json_pointer.cpp
folly/json/json.cpp
folly/lang/CString.cpp
folly/lang/SafeAssert.cpp
folly/lang/ToAscii.cpp
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ yoga-proguard-annotations = "1.19.0"
boost="1_83_0"
doubleconversion="1.1.6"
fmt="9.1.0"
folly="2024.01.01.00"
folly="2024.10.14.00"
glog="0.3.5"
gtest="1.12.1"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def test_installModulesDependencies_whenNewArchEnabledAndNewArchAndNoSearchPaths
spec = SpecMock.new

# Act
NewArchitectureHelper.install_modules_dependencies(spec, true, '2024.01.01.00')
NewArchitectureHelper.install_modules_dependencies(spec, true, '2024.10.14.00')

# Assert
folly_config = Helpers::Constants.folly_config
Expand All @@ -158,7 +158,7 @@ def test_installModulesDependencies_whenNewArchEnabledAndNewArchAndNoSearchPaths
spec.dependencies,
[
{ :dependency_name => "React-Core" },
{ :dependency_name => "RCT-Folly", "version"=>"2024.01.01.00" },
{ :dependency_name => "RCT-Folly", "version"=>"2024.10.14.00" },
{ :dependency_name => "glog" },
{ :dependency_name => "React-RCTFabric" },
{ :dependency_name => "ReactCodegen" },
Expand Down Expand Up @@ -190,7 +190,7 @@ def test_installModulesDependencies_whenNewArchDisabledAndSearchPathsAndCompiler
}

# Act
NewArchitectureHelper.install_modules_dependencies(spec, false, '2024.01.01.00')
NewArchitectureHelper.install_modules_dependencies(spec, false, '2024.10.14.00')

# Assert
assert_equal(Helpers::Constants.folly_config[:compiler_flags], "#{NewArchitectureHelper.folly_compiler_flags}")
Expand All @@ -200,7 +200,7 @@ def test_installModulesDependencies_whenNewArchDisabledAndSearchPathsAndCompiler
spec.dependencies,
[
{ :dependency_name => "React-Core" },
{ :dependency_name => "RCT-Folly", "version"=>"2024.01.01.00" },
{ :dependency_name => "RCT-Folly", "version"=>"2024.10.14.00" },
{ :dependency_name => "glog" },
{ :dependency_name => "React-RCTFabric" },
{ :dependency_name => "ReactCodegen" },
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/scripts/cocoapods/helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class Constants
}

@@folly_config = {
:version => '2024.01.01.00',
:version => '2024.10.14.00',
:git => 'https://github.com/facebook/folly.git',
:compiler_flags => '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_CFG_NO_COROUTINES=1 -DFOLLY_HAVE_CLOCK_GETTIME=1 -Wno-comma -Wno-shorten-64-to-32',
:dep_name => 'RCT-Folly/Fabric'
Expand Down
Loading

0 comments on commit e2bb08c

Please sign in to comment.