Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing listitem role do accessibiltiy doc #4352

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

6TELOIV
Copy link
Contributor

@6TELOIV 6TELOIV commented Nov 12, 2024

The accessibility doc seemed to be missing info about the listitem role, which is an important complementary role to the list role.

I added an entry for it with a simple description of the purpose.

@facebook-github-bot
Copy link

Hi @6TELOIV!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@6TELOIV
Copy link
Contributor Author

6TELOIV commented Nov 12, 2024

CLA signed.

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit bbe7b11
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6734d99366328e0008ee1c50
😎 Deploy Preview https://deploy-preview-4352--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@6TELOIV
Copy link
Contributor Author

6TELOIV commented Nov 12, 2024

Preview link seems to not have the change; not sure if I missed a step!

@6TELOIV
Copy link
Contributor Author

6TELOIV commented Nov 13, 2024

Found my change; visible at https://deploy-preview-4352--react-native.netlify.app/docs/next/accessibility#role (didn't realize it'd be under /next. It should apply to the current version as well, as it's an existing and supported feature, and is just missing from the docs)

@Simek
Copy link
Collaborator

Simek commented Nov 13, 2024

Hello @6TELOIV, thanks for the update! 👍

The versioned doc files are located in the directory linked below. Would be great if you can backport that change.

Also, would be nice to provide the context (PR/commit) when this role has been added, so we would know how far this change needs to be backported.

@6TELOIV
Copy link
Contributor Author

6TELOIV commented Nov 13, 2024

@Simek From what I can tell, commit a50e6fb added the listitem role. That would be v0.71.0. I'll update the pull request.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of the updates @6TELOIV, LGTM, welcome to the community! 🎉

@Simek Simek merged commit fa6a5f5 into facebook:main Nov 13, 2024
4 checks passed
@6TELOIV
Copy link
Contributor Author

6TELOIV commented Nov 13, 2024

Thanks! Y'all are doing awesome stuff, glad to contribute where I can! 😃

@6TELOIV 6TELOIV deleted the update-accessibility-listitem branch November 13, 2024 20:53
6TELOIV added a commit to 6TELOIV/react-native-website that referenced this pull request Nov 14, 2024
I erroneously added an extra bullet point in the 0.71 docs in front of the listitem entry in PR facebook#4352. This fixes it.
Simek pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants