-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing listitem role do accessibiltiy doc #4352
Conversation
Hi @6TELOIV! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
CLA signed. |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Preview link seems to not have the change; not sure if I missed a step! |
Found my change; visible at https://deploy-preview-4352--react-native.netlify.app/docs/next/accessibility#role (didn't realize it'd be under /next. It should apply to the current version as well, as it's an existing and supported feature, and is just missing from the docs) |
Hello @6TELOIV, thanks for the update! 👍 The versioned doc files are located in the directory linked below. Would be great if you can backport that change. Also, would be nice to provide the context (PR/commit) when this role has been added, so we would know how far this change needs to be backported. |
@Simek From what I can tell, commit a50e6fb added the listitem role. That would be v0.71.0. I'll update the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of the updates @6TELOIV, LGTM, welcome to the community! 🎉
Thanks! Y'all are doing awesome stuff, glad to contribute where I can! 😃 |
I erroneously added an extra bullet point in the 0.71 docs in front of the listitem entry in PR facebook#4352. This fixes it.
The accessibility doc seemed to be missing info about the
listitem
role, which is an important complementary role to thelist
role.I added an entry for it with a simple description of the purpose.