Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): update the debugging native code link. #4342

Closed
wants to merge 2 commits into from

Conversation

HammzaHM
Copy link
Contributor

@HammzaHM HammzaHM commented Nov 6, 2024

No description provided.

@facebook-github-bot
Copy link

Hi @HammzaHM!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit de620fb
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/672b5138544adb0008518813
😎 Deploy Preview https://deploy-preview-4342--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

docs/react-native-devtools.md Outdated Show resolved Hide resolved
Co-authored-by: Bartosz Kaszubowski <[email protected]>
@Simek
Copy link
Collaborator

Simek commented Nov 6, 2024

Okay @HammzaHM, I have a while to look at the problem a bit, the link you have changed was correct, and the double bracket is not a problem, let's revert this change.

Instead, we need to correct invalid links in the versioned docs, which are defined as an absolute http://localhost:3000 links by mistake:

  • React Native DevTools is designed for debugging React app concerns, and not to replace native tools. If you want to inspect React Native’s underlying platform layers (for example, while developing a Native Module), please use the debugging tools available in Xcode and Android Studio (see [Debugging Native Code](http://localhost:3000/docs/next/debugging-native-code)).
  • React Native DevTools is designed for debugging React app concerns, and not to replace native tools. If you want to inspect React Native’s underlying platform layers (for example, while developing a Native Module), please use the debugging tools available in Android Studio and Xcode (see [Debugging Native Code](http://localhost:3000/docs/next/debugging-native-code)).

Are you willing to follow up on this within current PR?

@cortinico
Copy link
Contributor

Closing as I think this is not necessary

@cortinico cortinico closed this Nov 6, 2024
@HammzaHM
Copy link
Contributor Author

HammzaHM commented Nov 7, 2024

@Simek I've made the changes requested by you in this PR #4344 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants