-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix debugging /docs/next/ redirects following 0.76 cut #4297
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aren't these still available under next? |
@blakef I'd assume that under We may yet have the unwanted behaviour of lack of redirects for older docs versions. |
website/static/_redirects
Outdated
/docs/next/architecture-overview /architecture/overview | ||
/docs/next/fabric-renderer /architecture/fabric-renderer | ||
/docs/next/render-pipeline /architecture/render-pipeline | ||
/docs/next/xplat-implementation /architecture/xplat-implementation | ||
/docs/next/view-flattening /architecture/view-flattening | ||
/docs/next/threading-model /architecture/threading-model | ||
/docs/next/architecture-glossary /architecture/glossary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add new redirect: both /docs/next/xyz
and /docs/xyz
should redirect to /architecture/xyz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any live references, elsewhere on the internet, to these old pages? IMO we don't need to be defensive with /next
links, and this will only kick the can down the road.
Potentially, there's another case we have been missing up to this point, in the other direction. We may want to add redirects from e.g. /docs/0.75/architecture-overview
(404) to /architecture/overview
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah, let me reduce this PR to debugging links only — will leave this with you.
60afd79
to
fbe801c
Compare
Updates redirects following #4294. Removed routes under
/docs/next
have now shipped under/docs
.