Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix debugging /docs/next/ redirects following 0.76 cut #4297

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

huntie
Copy link
Member

@huntie huntie commented Oct 23, 2024

Updates redirects following #4294. Removed routes under /docs/next have now shipped under /docs.

image

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit fbe801c
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/671a8b04a14a5e0008f9303d
😎 Deploy Preview https://deploy-preview-4297--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blakef
Copy link
Contributor

blakef commented Oct 23, 2024

Aren't these still available under next?

@huntie
Copy link
Member Author

huntie commented Oct 23, 2024

@blakef I'd assume that under /next, there are no references to old pages (now validated by CI, I believe).

We may yet have the unwanted behaviour of lack of redirects for older docs versions.

Comment on lines 85 to 91
/docs/next/architecture-overview /architecture/overview
/docs/next/fabric-renderer /architecture/fabric-renderer
/docs/next/render-pipeline /architecture/render-pipeline
/docs/next/xplat-implementation /architecture/xplat-implementation
/docs/next/view-flattening /architecture/view-flattening
/docs/next/threading-model /architecture/threading-model
/docs/next/architecture-glossary /architecture/glossary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add new redirect: both /docs/next/xyz and /docs/xyz should redirect to /architecture/xyz

Copy link
Member Author

@huntie huntie Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any live references, elsewhere on the internet, to these old pages? IMO we don't need to be defensive with /next links, and this will only kick the can down the road.

Potentially, there's another case we have been missing up to this point, in the other direction. We may want to add redirects from e.g. /docs/0.75/architecture-overview (404) to /architecture/overview etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yeah, let me reduce this PR to debugging links only — will leave this with you.

@huntie huntie changed the title [docs] Fix /docs/next/ redirects following 0.76 cut [docs] Fix debugging /docs/next/ redirects following 0.76 cut Oct 24, 2024
@cortinico cortinico merged commit 5af9de3 into facebook:main Oct 24, 2024
4 checks passed
@huntie huntie deleted the 0.76-cut-redirects branch October 24, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants