Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typos, code examples, and other inconsistencies in Native Development section #4290

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

amandeepmittal
Copy link
Contributor

@amandeepmittal amandeepmittal commented Oct 22, 2024

Why

After reviewing documents under "Native Development" section, I found a few inconsistencies and typos.

How

This PR:

  • Fixes the typos in code examples and the rest of the text for docs under Native Development section
  • Fixes minor formatting issues (such as using a period in a section heading)
  • Adds missing file titles for code in Cross-Platform with C++ guide
  • Updates commands for generating Pods in Cross-Platform with C++ guide with copy/pastable code blocks; this makes it consistent with the previous guide to perform the same step
  • Adds a missing command to create a new project in Modules > Android and iOS
  • Fixes the order of screenshots in Modules > Android and iOS > Step 4 Write your native Platform code > iOS (image 4 is used twice and image 6 was missing)

cc: @blakef

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit ff40b56
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6717a94d6b2b1f0008ccc3f9
😎 Deploy Preview https://deploy-preview-4290--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, LGTM! 👍

Copy link
Contributor

@blakef blakef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Much appreciated!

@blakef blakef merged commit c878206 into facebook:main Oct 22, 2024
4 checks passed
@amandeepmittal amandeepmittal deleted the aman/fix-inconsistencies branch October 22, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants