Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix small typos, in ViewStyle, ViewToken, Text docs #4237

Merged

Conversation

sorenfrederiksen
Copy link
Contributor

Documentation 📝

While reading the ViewStyle, ViewToken and Text documentation, I noticed some small typos and formatting inconsistencies that I thought I would correct.

Please see explanations for any that aren't clear-cut below. Please feel free to correct these changes, if I've misread expectations.

@@ -326,4 +326,4 @@ Controls whether the `View` can be the target of touch events.

| Type |
| --------------------------------------------- |
| enum('auto', 'box-none', 'box-only', 'none' ) |
| enum(`'auto'`, `'box-none'`, `'box-only'`, `'none'` ) |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other instances of enum values in this document appear enclosed in these back-ticks:

Screenshot 2024-09-29 at 21 03 57 Screenshot 2024-09-29 at 21 04 06 Screenshot 2024-09-29 at 21 04 13

Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 3da5fbb
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/66f9ae36fbc4640008ceea00
😎 Deploy Preview https://deploy-preview-4237--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -240,7 +240,7 @@ On Android, these roles have similar functionality on TalkBack as adding Accessi

Tells the screen reader to treat the currently focused on element as being in a specific state.

You can provide one state, no state, or multiple states. The states must be passed in through an object. Ex: `{selected: true, disabled: true}`.
You can provide one state, no state, or multiple states. The states must be passed in through an object, e.g. `{selected: true, disabled: true}`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The abbreviation "Ex:" isn't used anywhere else in the documentation, while "e.g." is used almost 900 times.

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and corrections, LGTM! 👍

@Simek Simek merged commit 2bf4b60 into facebook:main Sep 30, 2024
4 checks passed
@sorenfrederiksen sorenfrederiksen deleted the docs-fix-small-typos-formatting-issues branch September 30, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants