Fully revamp the 'Integration with an Android Fragment' page #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 26, 2024
…tentView` Summary: Fixes facebook#46566 Currently `ReactFragment` and `ReactDelegate` don't work in OSS + New Architecture because we call `Activity.setContentView` on the host activity. That result on us replacing the whole activity layout, even when the user wants to use a Fragment. As we do have `ReactActivityDelegate` that already does this: https://github.com/facebook/react-native/blob/94b77938435693792e57c96d76691d58d7361530/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java#L138 So this call is unncessary. I've also updated the relative documentation here: facebook/react-native-website#4232 Changelog: [Android] [Fixed] - fix: ReactDelegate/ReactFragment crashing on New Architecture apps Differential Revision: D63464367
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 26, 2024
…tentView` (facebook#46671) Summary: Pull Request resolved: facebook#46671 Fixes facebook#46566 Currently `ReactFragment` and `ReactDelegate` don't work in OSS + New Architecture because we call `Activity.setContentView` on the host activity. That result on us replacing the whole activity layout, even when the user wants to use a Fragment. As we do have `ReactActivityDelegate` that already does this: https://github.com/facebook/react-native/blob/94b77938435693792e57c96d76691d58d7361530/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java#L138 So this call is unncessary. I've also updated the relative documentation here: facebook/react-native-website#4232 Changelog: [Android] [Fixed] - fix: ReactDelegate/ReactFragment crashing on New Architecture apps Reviewed By: rozele Differential Revision: D63464367
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 27, 2024
…tentView` (#46671) Summary: Pull Request resolved: #46671 Fixes #46566 Currently `ReactFragment` and `ReactDelegate` don't work in OSS + New Architecture because we call `Activity.setContentView` on the host activity. That result on us replacing the whole activity layout, even when the user wants to use a Fragment. As we do have `ReactActivityDelegate` that already does this: https://github.com/facebook/react-native/blob/94b77938435693792e57c96d76691d58d7361530/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivityDelegate.java#L138 So this call is unncessary. I've also updated the relative documentation here: facebook/react-native-website#4232 Changelog: [Android] [Fixed] - fix: ReactDelegate/ReactFragment crashing on New Architecture apps Reviewed By: rozele Differential Revision: D63464367 fbshipit-source-id: acbfbf7d68eb79657b811a5a9a0d3f72660ec94a
cipolleschi
approved these changes
Oct 1, 2024
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Co-authored-by: Riccardo Cipolleschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refreshes the 'Integration with an Android Fragment' page and makes it fully working with New Architecture.