update examples to use cross-platform SafeAreaView #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@Simek @cortinico It seems the updated example code is not reflected in Deploy Preview link above. Is there some additional step that is missing? |
|
I have update only unversioned files, so to see the changes you need to select "Next" from the versions dropdown: |
alanleedev
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why & How
Update most of the
unversionedexamples to use cross-platformSafeAreaView, perform multiple tweaks and fixes to the existing code.Not every evample really needed the safe area container, but at the end for most of them, there is a value, so I have updated almost all examples to relay on
SafeAreaView, unless there is concrete reason to not wrap the code.Preview