-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions from CircleCI #4143
Migrate to GitHub Actions from CircleCI #4143
Conversation
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can we call the file pre-merge.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can we call the file pre-merge.yml
?
@cortinico Done as per your comments. |
@apicgg seems like both |
@cortinico Hey, yeah seems like the GitHub runner is picking up wrong path for the repo. I am checking this right now on how to fix. I have marked it as draft and will let you know once this is ready for review. |
We can use the |
@Simek Any idea why GH Actions is appending the working directory like below? For reference - Action Link |
This is probably throwing due to the configuration mistake (paths seems rigght). I would recommend making the lint and build a separate steps in the same workflow not separated jobs. If you want to retain the current division, you need to move the setup step in into both of the jobs ( |
@cortinico This is ready to review. The lint job is apparently taking longer with default GitHub Actions runners. |
@cortinico Do you also have in mind moving the deployments previews from CircleCI, or it was about PR checks only? |
@Simek I have pushed the changes now. |
I don't think we do deployments of Previews from CircleCI. |
Thank you very much for your help @apicgg 🙏 |
Fixes #4137