Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions from CircleCI #4143

Merged
merged 16 commits into from
Jun 12, 2024
Merged

Migrate to GitHub Actions from CircleCI #4143

merged 16 commits into from
Jun 12, 2024

Conversation

apicgg
Copy link
Contributor

@apicgg apicgg commented Jun 11, 2024

Fixes #4137

  • Set up Node environment.
  • Run lint script.
  • Run build script.

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 2ef6b13
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/666915984740ef000826f7ac
😎 Deploy Preview https://deploy-preview-4143--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

.github/workflows/cicd.yml Outdated Show resolved Hide resolved
.github/workflows/cicd.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we call the file pre-merge.yml?

.github/workflows/cicd.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can we call the file pre-merge.yml?

@apicgg
Copy link
Contributor Author

apicgg commented Jun 11, 2024

@cortinico Done as per your comments.

@cortinico
Copy link
Contributor

@apicgg seems like both build and lint are failing. Can you look into them and make them green?

@apicgg
Copy link
Contributor Author

apicgg commented Jun 11, 2024

@apicgg seems like both build and lint are failing. Can you look into them and make them green?

@cortinico Hey, yeah seems like the GitHub runner is picking up wrong path for the repo. I am checking this right now on how to fix. I have marked it as draft and will let you know once this is ready for review.

@apicgg apicgg marked this pull request as draft June 11, 2024 16:29
@Simek
Copy link
Collaborator

Simek commented Jun 11, 2024

I am checking this right now on how to fix.

We can use the working-directory: docs param for the scripts that need to be run from docs directory.

@apicgg
Copy link
Contributor Author

apicgg commented Jun 11, 2024

I am checking this right now on how to fix.

We can use the working-directory: docs param for the scripts that need to be run from docs directory.

@Simek Any idea why GH Actions is appending the working directory like below? For reference - Action Link

image

@Simek
Copy link
Collaborator

Simek commented Jun 11, 2024

This is probably throwing due to the configuration mistake (paths seems rigght). I would recommend making the lint and build a separate steps in the same workflow not separated jobs. If you want to retain the current division, you need to move the setup step in into both of the jobs (lint and build). needs only expects the successful run on mentioned job, but the checkouts are not shared.

@apicgg
Copy link
Contributor Author

apicgg commented Jun 11, 2024

@cortinico This is ready to review. The lint job is apparently taking longer with default GitHub Actions runners.

@apicgg apicgg marked this pull request as ready for review June 11, 2024 18:16
@apicgg apicgg requested a review from cortinico June 11, 2024 18:16
@Simek
Copy link
Collaborator

Simek commented Jun 11, 2024

@cortinico Do you also have in mind moving the deployments previews from CircleCI, or it was about PR checks only?

@apicgg
Copy link
Contributor Author

apicgg commented Jun 12, 2024

@Simek I have pushed the changes now.

@cortinico
Copy link
Contributor

Do you also have in mind moving the deployments previews from CircleCI, or it was about PR checks only?

I don't think we do deployments of Previews from CircleCI.

@cortinico cortinico merged commit c8ad765 into facebook:main Jun 12, 2024
7 checks passed
@cortinico
Copy link
Contributor

Thank you very much for your help @apicgg 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help us migrate to GitHub Actions
4 participants