Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plot.py #2523

Merged
merged 1 commit into from
May 18, 2024
Merged

Update plot.py #2523

merged 1 commit into from
May 18, 2024

Conversation

tomthepeach
Copy link
Contributor

Removed depreciated/unnecessary datetime conversion

Removed depreciated/unnecessary datetime conversion
@facebook-github-bot
Copy link
Contributor

Hi @tomthepeach!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@tcuongd
Copy link
Collaborator

tcuongd commented Nov 6, 2023

Could you please provide some example plots from your branch to validate that the functionality is still working as intended, thanks!

@tcuongd tcuongd self-requested a review November 6, 2023 09:51
@tomthepeach
Copy link
Contributor Author

image

@tomthepeach
Copy link
Contributor Author

This is using my fork built locally in a venv

@tomthepeach
Copy link
Contributor Author

tomthepeach commented Nov 6, 2023

This solves issue #2492

@tomthepeach
Copy link
Contributor Author

@tcuongd Ok to merge?

Copy link
Collaborator

@tcuongd tcuongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and sorry for the long review lag.

@tcuongd tcuongd merged commit f89de32 into facebook:main May 18, 2024
6 checks passed
YuyuZhou1228 added a commit to YuyuZhou1228/prophet that referenced this pull request Jul 13, 2024
an extension of facebook#2523, removed remaining instances of the depreciated and unnecessary use of .dt.to_pydatetime()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants