[lexical-react] Bug Fix: useCharacterLimit AutoLink infinite loop bug #6662

[redstar08]

Description

Bug Fix: useCharacterLimit AutoLink infinite loop bug #6662

Steps to Reproduce

• add CharacterLimitPlugin and AutoLinkPlugin or LinkPlugin
• type a link in overflow node

Current Behaviour:

• when type a link in overflow node infinite loop in useCharacterLimit -> $wrapOverflowedNodes

New Behaviour:

• autolink is ok in overflow node

Test plan

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 9:44am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 9:44am

[facebook-github-bot]

Hi @redstar08!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	29.85 KB (0%)
lexical - esm	29.66 KB (0%)
@lexical/rich-text - cjs	38.3 KB (0%)
@lexical/rich-text - esm	31.55 KB (0%)
@lexical/plain-text - cjs	36.9 KB (0%)
@lexical/plain-text - esm	28.86 KB (0%)
@lexical/react - cjs	40.08 KB (0%)
@lexical/react - esm	32.91 KB (0%)

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[etrepum]

It does seem strange that this would be the best way to fix this bug. Ideally this wouldn't need to know anything about node types other than TextNode, ElementNode and DecoratorNode. Seems like a problem that is in the algorithm either here or in AutoLinkNode (e.g. if it's "grabbing" text from too far outside of its container). If we were to rewrite the character limit plugin in its own package without a react dependency it would be unexpected that it depends on the link package.

[redstar08]

It does seem strange that this would be the best way to fix this bug. Ideally this wouldn't need to know anything about node types other than TextNode, ElementNode and DecoratorNode. Seems like a problem that is in the algorithm either here or in AutoLinkNode (e.g. if it's "grabbing" text from too far outside of its container). If we were to rewrite the character limit plugin in its own package without a react dependency it would be unexpected that it depends on the link package.

The analysis is quite correct, it's seems to be the fastest, but not the best solution, and I try to reconsider from the algorithm in the $wrapOverflowedNodes function, and think a way how to avoid judging directly by AutoLink node.