Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Feat: Cannot insert table into table #6509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

keiseiTi
Copy link
Contributor

Description

In notion or other editors, cannot insert a table into a table

Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 9:31am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2024 9:31am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 10, 2024
Copy link

github-actions bot commented Aug 10, 2024

size-limit report 📦

Path Size
lexical - cjs 29.25 KB (0%)
lexical - esm 29.11 KB (0%)
@lexical/rich-text - cjs 37.66 KB (0%)
@lexical/rich-text - esm 30.9 KB (0%)
@lexical/plain-text - cjs 36.24 KB (0%)
@lexical/plain-text - esm 28.29 KB (0%)
@lexical/react - cjs 39.52 KB (0%)
@lexical/react - esm 32.39 KB (0%)

@ivailop7
Copy link
Collaborator

I proposed this functionality some time ago, but was rejected. Someone even fixed the table in table selection logic. Unlikely to be merged. It's also the type of feature that can be implemented on playground-level for those that want it.

@etrepum
Copy link
Collaborator

etrepum commented Aug 11, 2024

@ivailop7 this PR prevents tables from being inserted into tables, seems like a win unless someone is planning to fix all of the bugs with nested tables?

@ivailop7
Copy link
Collaborator

ivailop7 commented Aug 11, 2024

I'd rather have the merged cells issues fixed first. They are the weakest point of tables right now. I've labelled all the tables issues, in case someone wants to have a go at them. I'm in favour of disabling table withing table, but need the rest of the core folks to chime in as well @zurfyx and @StyleT, @fantactuka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants