Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-markdown] Refactor: Move Transformer Groups from index to MarkdownTransformers #6474

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jkjk822
Copy link
Contributor

@jkjk822 jkjk822 commented Jul 29, 2024

Description

Move transformer groups created in index.ts to MarkdownTransformers.ts. This feels cleaner as it co-locates them with the member transformers as well as avoiding a cyclical dependency involving index.ts and MarkdownShortcut.ts.

Test plan

N/A, current tests pass, which should suffice.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 7:01pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 7:01pm

@facebook-github-bot
Copy link
Contributor

Hi @jkjk822!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

github-actions bot commented Jul 29, 2024

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.24 KB (0%)
@lexical/rich-text - cjs 37.89 KB (0%)
@lexical/rich-text - esm 31.07 KB (0%)
@lexical/plain-text - cjs 36.49 KB (0%)
@lexical/plain-text - esm 28.41 KB (0%)
@lexical/react - cjs 39.64 KB (0%)
@lexical/react - esm 32.51 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants