Skip to content

Commit

Permalink
Apply linters to idb py root
Browse files Browse the repository at this point in the history
Summary: Somethings to lint

Reviewed By: zeyadsalloum

Differential Revision: D19411755

fbshipit-source-id: db12a48862c25d1881fd924ae7dcf337723a47c0
  • Loading branch information
lawrencelomax authored and facebook-github-bot committed Jan 16, 2020
1 parent 18236c8 commit 3f5e6d7
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion idb/cli/commands/xctest.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def get_tests_to_run(self, args: Namespace) -> Optional[Set[str]]:
tests = tests[:-1]
# the companion is expecting a set of size one for the logic tests,
# that is why we parse it here
return set([tests])
return {tests}
return None


Expand Down
2 changes: 1 addition & 1 deletion idb/client/grpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ async def list_test_bundle(self, test_bundle_id: str, app_path: str) -> List[str
response = await self.stub.xctest_list_tests(
XctestListTestsRequest(bundle_name=test_bundle_id, app_path=app_path)
)
return [name for name in response.names]
return list(response.names)

async def list_xctests(self) -> List[InstalledTestInfo]:
response = await self.stub.xctest_list_bundles(XctestListBundlesRequest())
Expand Down
8 changes: 4 additions & 4 deletions idb/common/command.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
#!/usr/bin/env python3
# Copyright (c) Facebook, Inc. and its affiliates. All Rights Reserved.
# Copyright (c) Facebook, Inc. and its affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

from abc import ABCMeta, abstractmethod
from argparse import ArgumentParser, Namespace
from logging import Logger, getLogger
from typing import Dict, List, Optional

from idb.common import logging, plugin


class Command(metaclass=ABCMeta):
@property
Expand Down
2 changes: 0 additions & 2 deletions idb/common/tests/format_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

import json

from idb.common.format import (
installed_app_info_from_json,
installed_test_info_from_json,
Expand Down

0 comments on commit 3f5e6d7

Please sign in to comment.