Allow optional newline in OpenSSL output #9289
Open
Commits on Nov 2, 2022
-
Differential Revision: D40942193 fbshipit-source-id: 87117195d1afe3ddf2daddd20947478f8210db6b
-
Extract public key portion via PEM roundtrip (facebook#9282)
Summary: This diff applies the approach similar to php/php-src@26a51e8 in order to fix behavior changes in OpenSSL 3 Pull Request resolved: facebook#9282 Test Plan: The existing tests should still pass with OpenSSL 1.1 ``` "$HHVM_BIN" hphp/test/run.php hphp/test/slow/ext_openssl/ext_openssl.php ``` Differential Revision: D40876120 Pulled By: Atry fbshipit-source-id: 402e333b76853d70931f6898dd15ae9e88d8ecd8
-
Differential Revision: D40942189 fbshipit-source-id: 6383c8922e5b9118582fba72a923d3d5d19380c2
-
Allow optional newline in OpenSSL output
Summary: OpenSSL 3 does not include the trailing newline in its output. This diff adjust `expectf` so that it is now compatible with both OpenSSL 1.1 and 3.0. Differential Revision: D40942191 fbshipit-source-id: 300a35d617566f4335b04c4d7fab03ec774aecf1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.