Add test for for Dsf update failing

Summary: As titled

Reviewed By: zechengh09

Differential Revision:
D62064161

Privacy Context Container: L1125642

fbshipit-source-id: 5eb31e0784d2b9f02559973f04ac73fac8d195d8

fboss/agent/DsfSubscription.h

@@ -115,6 +115,8 @@ class DsfSubscription {
   template <typename T>
   FRIEND_TEST(DsfSubscriptionTest, updateWithRollbackProtection);
   template <typename T>
+  FRIEND_TEST(DsfSubscriptionTest, updateFailed);
+  template <typename T>
   FRIEND_TEST(DsfSubscriptionTest, setupNeighbors);
 };
 

fboss/agent/test/DsfSubscriptionTests.cpp

@@ -4,6 +4,7 @@
 #include "fboss/agent/AgentFsdbSyncManager.h"
 #include "fboss/agent/DsfSubscription.h"
 #include "fboss/agent/SwitchStats.h"
+#include "fboss/agent/hw/mock/MockPlatform.h"
 #include "fboss/agent/test/CounterCache.h"
 #include "fboss/agent/test/HwTestHandle.h"
 #include "fboss/agent/test/TestUtils.h"
@@ -15,6 +16,8 @@
 #include <gtest/gtest.h>
 #include "fboss/agent/GtestDefs.h"
 
+using ::testing::_;
+using ::testing::Return;
 namespace facebook::fboss {
 namespace {
 constexpr auto kRemoteSwitchIdBegin = 4;
@@ -361,6 +364,44 @@ TYPED_TEST(DsfSubscriptionTest, DataUpdate) {
       this->getRemoteSystemPorts()->size(), this->kNumRemoteSwitchAsics + 1));
 }
 
+TYPED_TEST(DsfSubscriptionTest, updateFailed) {
+  CounterCache counters(this->sw_);
+  this->createPublisher();
+  auto state = this->makeSwitchState();
+  this->publishSwitchState(state);
+
+  std::optional<std::map<SwitchID, std::shared_ptr<SystemPortMap>>>
+      recvSysPorts;
+  std::optional<std::map<SwitchID, std::shared_ptr<InterfaceMap>>> recvIntfs;
+  this->subscription_ = this->createSubscription();
+
+  WITH_RETRIES({
+    ASSERT_EVENTUALLY_EQ(
+        this->getRemoteSystemPorts()->size(), this->kNumRemoteSwitchAsics);
+    ASSERT_EVENTUALLY_EQ(
+        this->getRemoteInterfaces()->size(), this->kNumRemoteSwitchAsics);
+    EXPECT_EQ(this->dsfSessionState(), DsfSessionState::WAIT_FOR_REMOTE);
+  });
+  waitForStateUpdates(this->sw_);
+
+  // Fail HW update by returning current state
+  EXPECT_HW_CALL(this->sw_, stateChangedImpl(_))
+      .Times(::testing::AtLeast(1))
+      .WillOnce(Return(this->sw_->getState()));
+  auto sysPort2 = makeSysPort(
+      std::nullopt, SystemPortID(kSysPortRangeMin + 2), kRemoteSwitchIdBegin);
+  auto portMap = state->getSystemPorts()->modify(&state);
+  portMap->addNode(sysPort2, this->matcher());
+  this->publishSwitchState(state);
+  auto dsfUpdateFailedCounter =
+      SwitchStats::kCounterPrefix + "dsf_update_failed.sum.60";
+  WITH_RETRIES({
+    counters.update();
+    ASSERT_EVENTUALLY_TRUE(counters.checkExist(dsfUpdateFailedCounter));
+    ASSERT_EVENTUALLY_EQ(counters.value(dsfUpdateFailedCounter), 1);
+  });
+}
+
 TYPED_TEST(DsfSubscriptionTest, updateWithRollbackProtection) {
   auto sysPorts = makeSysPortsForSwitchIds(
       std::set<SwitchID>({SwitchID(kRemoteSwitchIdBegin)}), 2);