Skip to content

Commit

Permalink
More Agent OSS build fixes
Browse files Browse the repository at this point in the history
Summary: Adds required cmake dependencies for `hw_switch_reachability_change_speed` and removes unused variables.

Reviewed By: srikrishnagopu

Differential Revision: D63040254

fbshipit-source-id: 04e16dc2c3afc9a714675c645cf9cfa33b5c26c5
  • Loading branch information
paulcruz74 authored and facebook-github-bot committed Sep 20, 2024
1 parent e289fbd commit 964d3d1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 2 additions & 0 deletions cmake/AgentHwBenchmarks.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,8 @@ target_link_libraries(hw_switch_reachability_change_speed
mono_agent_ensemble
mono_agent_benchmarks
config_factory
voq_test_utils
fabric_test_utils
Folly::folly
Folly::follybenchmark
)
5 changes: 0 additions & 5 deletions fboss/agent/test/agent_hw_tests/AgentHwAclQualifierTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,6 @@ TEST_F(AgentHwAclQualifierTest, AclIp4TcpQualifiers) {
auto& ensemble = *getAgentEnsemble();
auto newCfg = initialConfig(ensemble);
auto l3Asics = ensemble.getSw()->getHwAsicTable()->getL3Asics();
auto asic = utility::checkSameAndGetAsic(l3Asics);

auto* acl1 = utility::addAcl(&newCfg, "ip4_tcp", cfg::AclActionType::DENY);
configureAllHwQualifiers(acl1, true);
Expand Down Expand Up @@ -290,7 +289,6 @@ TEST_F(AgentHwAclQualifierTest, AclIp6TcpQualifiers) {
auto& ensemble = *getAgentEnsemble();
auto newCfg = initialConfig(ensemble);
auto l3Asics = ensemble.getSw()->getHwAsicTable()->getL3Asics();
auto asic = utility::checkSameAndGetAsic(l3Asics);

auto* acl1 = utility::addAcl(&newCfg, "ip6_tcp", cfg::AclActionType::DENY);
configureAllHwQualifiers(acl1, true);
Expand Down Expand Up @@ -321,7 +319,6 @@ TEST_F(AgentHwAclQualifierTest, AclIcmp4Qualifiers) {
auto& ensemble = *getAgentEnsemble();
auto newCfg = initialConfig(ensemble);
auto l3Asics = ensemble.getSw()->getHwAsicTable()->getL3Asics();
auto asic = utility::checkSameAndGetAsic(l3Asics);

auto* acl1 = utility::addAcl(&newCfg, "icmp4", cfg::AclActionType::DENY);
configureAllHwQualifiers(acl1, true);
Expand Down Expand Up @@ -350,7 +347,6 @@ TEST_F(AgentHwAclQualifierTest, AclIcmp6Qualifiers) {
auto& ensemble = *getAgentEnsemble();
auto newCfg = initialConfig(ensemble);
auto l3Asics = ensemble.getSw()->getHwAsicTable()->getL3Asics();
auto asic = utility::checkSameAndGetAsic(l3Asics);

auto* acl1 = utility::addAcl(&newCfg, "icmp6", cfg::AclActionType::DENY);
configureAllHwQualifiers(acl1, true);
Expand All @@ -376,7 +372,6 @@ TEST_F(AgentHwAclQualifierTest, AclRemove) {
auto& ensemble = *getAgentEnsemble();
auto newCfg = initialConfig(ensemble);
auto l3Asics = ensemble.getSw()->getHwAsicTable()->getL3Asics();
auto asic = utility::checkSameAndGetAsic(l3Asics);

auto* acl0 = utility::addAcl(&newCfg, "acl0", cfg::AclActionType::DENY);
acl0->proto() = 6;
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/test/agent_hw_tests/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ cpp_library(
"//fboss/agent/test/utils:voq_test_utils",
"//fboss/lib:common_utils",
"//folly:file_util",
"//folly:map_util",
"//folly:network_address",
"//folly/json:dynamic",
"//folly/logging:logging",
Expand Down

0 comments on commit 964d3d1

Please sign in to comment.