Skip to content

Commit

Permalink
add new FBOSS feature NO_RX_REASON_TRAP
Browse files Browse the repository at this point in the history
Summary: This new feature is used for replacing rx reason trap by ACL and only enabled on J3 right now.

Reviewed By: shri-khare

Differential Revision:
D61854930

Privacy Context Container: L1125642

fbshipit-source-id: f2f306ecd69d662a1ca804ee8235510712bc53ea
  • Loading branch information
daiwei1983 authored and facebook-github-bot committed Aug 28, 2024
1 parent b514d56 commit 2418bcc
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 0 deletions.
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/EbroAsic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ bool EbroAsic::isSupportedNonFabric(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
case HwAsic::Feature::SAI_ACL_ENTRY_SRC_PORT_QUALIFIER:
/*
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/GaronneAsic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ bool GaronneAsic::isSupported(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down
3 changes: 3 additions & 0 deletions fboss/agent/hw/switch_asics/HwAsic.h
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ class HwAsic {
EGRESS_CORE_BUFFER_WATERMARK,
DELETED_CREDITS_STAT,
INGRESS_PRIORITY_GROUP_DROPPED_PACKETS,
// replace all ACL based trap reasons by
// explicty ACL config programmed by FBOSS
NO_RX_REASON_TRAP,
};

enum class AsicMode {
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/Jericho2Asic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ bool Jericho2Asic::isSupported(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/Jericho3Asic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ bool Jericho3Asic::isSupported(Feature feature) const {
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::ROUTE_METADATA:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return true;
// Features not expected to work on SIM
case HwAsic::Feature::SHARED_INGRESS_EGRESS_BUFFER_POOL:
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/Tomahawk3Asic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ bool Tomahawk3Asic::isSupported(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/Tomahawk4Asic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ bool Tomahawk4Asic::isSupported(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/Tomahawk5Asic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ bool Tomahawk5Asic::isSupported(Feature feature) const {
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::RX_SNR:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/TomahawkAsic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ bool TomahawkAsic::isSupported(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/Trident2Asic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ bool Trident2Asic::isSupported(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down
1 change: 1 addition & 0 deletions fboss/agent/hw/switch_asics/YubaAsic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ bool YubaAsic::isSupportedNonFabric(Feature feature) const {
case HwAsic::Feature::EGRESS_CORE_BUFFER_WATERMARK:
case HwAsic::Feature::DELETED_CREDITS_STAT:
case HwAsic::Feature::INGRESS_PRIORITY_GROUP_DROPPED_PACKETS:
case HwAsic::Feature::NO_RX_REASON_TRAP:
return false;
}
return false;
Expand Down

0 comments on commit 2418bcc

Please sign in to comment.