Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make curl debug output more user friendly #557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Jan 21, 2020

  1. Make curl debug output more user friendly

    The curl output helps when debugging requests made to the FB API.
    
    However it's not as user friendly as it should be because it retrieves
    gzipped content which can't immediately be displayed when running the
    curl command in the terminal. See the below post by the curl maintainer
    on why binary output is no longer displayed in stdout by default.
    
    https://daniel.haxx.se/blog/2017/06/17/curl-doesnt-spew-binary-anymore/
    
    Instead of displaying binary output I force the API to return
    uncompressed JSON which can immediately be displayed when running the
    command. See the below two examples.
    
    Without this patch:
    ```
    $ curl -X GET -H 'Accept: application/json' -H 'Accept-Encoding: gzip, deflate' -H 'Connection: keep-alive' -H 'User-Agent: fbbizsdk-python-v5.0.1' 'https://graph.facebook.com/v5.0/me/adaccounts?access_token=xxxxxx&summary=true'
    Warning: Binary output can mess up your terminal. Use "--output -" to tell
    Warning: curl to output it to your terminal anyway, or consider "--output
    Warning: <FILE>" to save to a file.
    ```
    
    With this patch:
    ```
    $ curl -X GET -H 'Accept: application/json' -H 'Connection: keep-alive' -H 'User-Agent: fbbizsdk-python-v5.0.1' 'https://graph.facebook.com/v5.0/me/adaccounts?access_token=xxxxxx&summary=true'
    {"data":[{"account_id":"abc","id":"act_abc"},"summary":{"total_count":1}}
    ```
    danihodovic committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    0abc616 View commit details
    Browse the repository at this point in the history