Removing 'status' field from ad objects.

Summary: 'status' needs to be passed as a parameter in create and update calls. It is not allowed as a field any longer. Test Plan: Updated Integration tests per this changes. All tests pass
facebook · Oct 20, 2015 · df6365a · df6365a
1 parent 4c28237
commit df6365a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/facebookads/mixins.py b/facebookads/mixins.py
@@ -56,7 +56,7 @@ def remote_delete(
     ):
         return self.remote_update(
             params={
-                self.Field.status: self.Status.deleted,
+                'status': self.Status.deleted,
             },
             batch=batch,
             failure=failure,
@@ -75,7 +75,7 @@ def remote_archive(
     ):
         return self.remote_update(
             params={
-                self.Field.status: self.Status.archived,
+                'status': self.Status.archived,
             },
             batch=batch,
             failure=failure,

diff --git a/facebookads/objects.py b/facebookads/objects.py
@@ -1262,7 +1262,6 @@ class Field(object):
         name = 'name'
         objective = 'objective'
         promoted_object = 'promoted_object'
-        status = 'status'
 
     class BuyingType(object):
         auction = 'AUCTION'
@@ -1321,7 +1320,6 @@ class Field(HasBidInfo, object):
         rf_prediction_id = 'rf_prediction_id'
         rtb_flag = 'rtb_flag'
         start_time = 'start_time'
-        status = 'status'
         targeting = 'targeting'
         updated_time = 'updated_time'
 
@@ -1401,7 +1399,6 @@ class Field(HasBidInfo, object):
         name = 'name'
         redownload = 'redownload'
         social_prefs = 'social_prefs'
-        status = 'status'
         tracking_specs = 'tracking_specs'
         updated_time = 'updated_time'
         view_tags = 'view_tags'
@@ -2734,8 +2731,8 @@ class Field(object):
         campaign_id = 'campaign_id'
         campaign_name = 'campaign_name'
         cost_per_action_type = 'cost_per_action_type'
-        cost_per_inline_link_click = 'cost_per_inline_link_click',
-        cost_per_inline_post_engagement = 'cost_per_inline_post_engagement',
+        cost_per_inline_link_click = 'cost_per_inline_link_click'
+        cost_per_inline_post_engagement = 'cost_per_inline_post_engagement'
         cost_per_total_action = 'cost_per_total_action'
         cost_per_unique_click = 'cost_per_unique_click'
         cpm = 'cpm'
@@ -2746,8 +2743,8 @@ class Field(object):
         frequency = 'frequency'
         id = 'id'
         impressions = 'impressions'
-        inline_link_clicks = 'inline_link_clicks',
-        inline_post_engagement = 'inline_post_engagement',
+        inline_link_clicks = 'inline_link_clicks'
+        inline_post_engagement = 'inline_post_engagement'
         reach = 'reach'
         relevance_score = 'relevance_score'
         report_run_id = 'report_run_id'

diff --git a/facebookads/test/integration.py b/facebookads/test/integration.py
@@ -114,7 +114,7 @@ def new_test_ad_set(self, campaign):
         ad_set.update({
             objects.AdSet.Field.name: 'AdSetTestCase %s' % self.TEST_ID,
             objects.AdSet.Field.campaign_id: campaign_id,
-            objects.AdSet.Field.status: objects.AdSet.Status.paused,
+            'status': objects.AdSet.Status.paused,
             objects.AdSet.Field.pacing_type: [
                 objects.AdSet.PacingType.standard,
             ],
@@ -169,7 +169,7 @@ def new_test_ad(self, ad_set):
             objects.Ad.Field.creative: {
                 objects.Ad.Field.Creative.creative_id: creative_id,
             },
-            objects.Ad.Field.status: objects.Ad.Status.paused,
+            'status': objects.Ad.Status.paused,
         })
 
         return ad
@@ -303,7 +303,7 @@ def test_can_select_api_version(self):
 
         test_image_one[objects.AdImage.Field.filename] = image_file
 
-        assert test_image_one.remote_create(api_version="v2.4") is not None
+        assert test_image_one.remote_create(api_version="v2.5") is not None
 
         test_image_two = objects.AdImage(
             parent_id=self.TEST_ACCOUNT.get_id_assured(),
@@ -312,7 +312,7 @@ def test_can_select_api_version(self):
         test_image_two[objects.AdImage.Field.filename] = image_file
 
         try:
-            test_image_two.remote_create(api_version="v2.4")
+            test_image_two.remote_create(api_version="v2.5")
         except fbexceptions.FacebookBadObjectError as e:
             assert e is not None