Fix: Cursor.php return type hint breaks php < 8 #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue introduced in versions > 15.0.2 when current() function doc line: "* @return AbstractObject|bool" was changed by return type hint: "public function current() : AbstractObject|bool {" Changed current() return typing from AbstractObject|bool to AbstractObject|null to better match what you would expect
|
Hi @sesanzb thanks for submitting the pull request. We are considering dropping the support of PHP version < 8 for now. So this pull request might not be merged. |
|
Hi @stcheng ! |
|
@sesanzb right now we don't branch out older versions but only tag them. so since v16 has already released on top of the master branch, we're dropping the support since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue introduced in versions > 15.0.2
when current() function doc line: "* @return AbstractObject|bool" was changed by return type hint: "public function current() : AbstractObject|bool {"
Changed current() return typing from AbstractObject|bool to AbstractObject|null to better match what you would expect