add check for JSON string #186
Conversation
I'm getting:
{
"errorType": "Error",
"errorMessage": "Error: SyntaxError: Unexpected token < in JSON at position 0 with code: 1",
"stack": [
"Error: Error: SyntaxError: Unexpected token < in JSON at position 0 with code: 1",
" at _homogeneousError (/var/runtime/CallbackContext.js:12:12)",
" at postError (/var/runtime/CallbackContext.js:29:54)",
" at callback (/var/runtime/CallbackContext.js:41:7)",
" at /var/runtime/CallbackContext.js:104:16",
" at /var/task/handler.js:15:13",
" at processTicksAndRejections (internal/process/task_queues.js:97:5)"
]
}
body is not a JSON string and failing
|
Hi @KennethChiu123! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| body = typeof body === 'string' && isJsonString(body) ? JSON.parse(body) : body; | ||
| // Construct an error message from subfields in body.error | ||
| message = body.error.error_user_msg |
There was a problem hiding this comment.
if the body is a string. it will fail here...
I'm getting:
{
"errorType": "Error",
"errorMessage": "Error: SyntaxError: Unexpected token < in JSON at position 0 with code: 1",
"stack": [
"Error: Error: SyntaxError: Unexpected token < in JSON at position 0 with code: 1",
" at _homogeneousError (/var/runtime/CallbackContext.js:12:12)",
" at postError (/var/runtime/CallbackContext.js:29:54)",
" at callback (/var/runtime/CallbackContext.js:41:7)",
" at /var/runtime/CallbackContext.js:104:16",
" at /var/task/handler.js:15:13",
" at processTicksAndRejections (internal/process/task_queues.js:97:5)"
]
}
body is not a JSON string and failing