Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack 5 #11201

Merged
merged 35 commits into from
Aug 4, 2021
Merged

Webpack 5 #11201

merged 35 commits into from
Aug 4, 2021

Conversation

raix
Copy link
Contributor

@raix raix commented Jul 12, 2021 •
edited
Loading

WP5 branch

  • Updating webpack to v5
  • Update dependencies related to webpack 5
  • Update postcss to v8
  • Fix eslint shareable config to be self contained regarding dependencies
  • Testing Webpack 5 error overlay instead of the CRA overlay (ref: outstanding formatting issue)

Breaking changes:

  • No node js builtin shims (breaking as in Webpack 5)
  • Removed WatchMissingNodeModulesPlugin
  • Dropped node v10 + v12 support
  • Webpack Development Server pathname default is now "/ws" (prev: '/sockjs-node')

Closing #9994

raix and others added 2 commits May 28, 2021 09:32
@raix @ianschmitz
@jasonwilliams @Spacerat @shamprasadrh @jamesgeorge007
[WP5] Webpack5 update (#10961)
aaddb29 
* Revert "Revert "Update postcss packages" (#10216)"

This reverts commit 3968923.

* Revert "Update postcss packages" (#10216)

This reverts commit 580ed5d.

* Update postcss and loader

* Update [email protected]

References:
* [hook rename](TypeStrong/fork-ts-checker-webpack-plugin#490)
* [include/exclude](TypeStrong/fork-ts-checker-webpack-plugin#450) and [issue options](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin#issues-options)
* [release notes 5.0.0](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/releases/tag/v5.0.0)

* Update fork-ts-checker-webpack-plugin 6.0.5

* Add [email protected] remove

Add [email protected]
Remove optimize-css-assets-webpack-plugin and postcss-safe-parser

References:
* https://webpack.js.org/plugins/css-minimizer-webpack-plugin/

* Add support for Webpack 5 message objects

* Update WebpackManifestPlugin to v3.0.0

* Support both "SingleEntryPlugin" and "EntryPlugin"

* Support Webpack 5 IgnorePlugin signature

Reference:
* https://webpack.js.org/plugins/ignore-plugin/#example-of-ignoring-moment-locales
* #10006

* Update webpack and dev server

* Enable persistent cache

* Fix react-error-overlay webpack

* Fix dev server config

* Remove support for SingleEntryPlugin

* update workbox-webpack-plugin

* Fix post css config

* Comment out WebpackManifestPlugin for now having issues with undefined path

* Add fast refresh entries to ModuleScopePlugin

* Format files

* Remove unused variables in start command

* git ignore tsconfig.tsbuildinfo
supporting incremental typescript builds

* simplify output path

review feedback from @kumarlachhani

* Use asset modules in react-scripts

* Use asset modules in react-error-overlay

* eslint-config-react-app typo fix (#10317)

This just fixes a shell snippet in the readme file for this plugin

* Fix link address (#10907)

Replace the Github home link with a link to the repo's main page or a link to the source (https://github.com/CodeByZach/pace/blob/master/pace.js)

* Bump immer version for fixing security issue (#10791)

Bump immer minor version to fix `Prototype Pollution` Security issue.

* test(create-react-app): add integration tests (#10381)

* Revert "Use asset modules in react-error-overlay"

This reverts commit 952f896.

* Disable broken tests for now

* Revert source-map bump in react-error-overlay

* JSON is using default export

* Webpack config: Remove invalid parser configuration

* Fix issue with ModuleScope and babel runtime

* Fix svgr configuration

* Webpack config svg use file-loader instead of url-loader

* Update postcss-normalize

* Fix asset output name

* Update test matrix using node 12+14

postcss normalize only support node >=12

* Fix file output extension

* Align assetModuleFilename

* pipeline update configuration names

* Add back webpack-manifest-plugin

* Fix kitchen sink get actual href value

.href is prefixed with http://localhost etc.

* Update kitchen sink test to webpack 5 asset modules

* Let webpack handle global this

* Fix eject copy config/webpack/persistentCache folder

* Move tsbuildinfo into cache folder

* Update dependencies

* Update webpack-dev-server to beta.3

* Compilation.modules changed to type Set

reference: comment by @slorber #9994 (comment)

* Format JsonInclusion.js using prettier

* Run prettier on webpack dev server config

* Enable e2e behavior tests using node 12+14

* Comment out e2e behavior tests for now

* Add experimental support for module federation

* Fix missing wds socket path update

accordingly to review by @xiaokekeT

* Revert "Add experimental support for module federation"

This reverts commit 8fdc63b.

Co-authored-by: Ian Schmitz <[email protected]>
Co-authored-by: jasonwilliams <[email protected]>
Co-authored-by: Joseph Atkins-Turkish <[email protected]>
Co-authored-by: e-w-h <[email protected]>
Co-authored-by: Shamprasad RH <[email protected]>
Co-authored-by: James George <[email protected]>
Update Webpack dependencies and fix minor issues (#11170)
da654e6
mrmckeb
mrmckeb reviewed Jul 14, 2021
View reviewed changes
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
azure-pipelines-test-job.yml Outdated Show resolved Hide resolved
iansu
iansu suggested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@iansu iansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I had a few questions and noticed there are some conflicts. Let's get this merged as soon as we can and get an alpha release out.

azure-pipelines.yml Show resolved Hide resolved
packages/react-scripts/config/webpack/persistentCache/createEnvironmentHash.js Outdated Show resolved Hide resolved
packages/react-dev-utils/WebpackDevServerUtils.js Show resolved Hide resolved
packages/react-scripts/config/pnpTs.js Show resolved Hide resolved
packages/react-scripts/config/webpack.config.js Show resolved Hide resolved
packages/react-scripts/scripts/start.js Show resolved Hide resolved
@mrmckeb
Copy link
Contributor

mrmckeb commented Jul 14, 2021

This is looking great. @iansu and I left a few comments, and also wanted to note that we merged this:
#11105

There are a few conflicts, but it looks like 95% of those are just version-related.

@kryptonitechic
Copy link

5 /prouh

  • ouna de lay Rojo bekino tegak / l pitch Zain mothe on

@raix raix mentioned this pull request Jul 16, 2021
Open
@raix raix added this to the 5.0 milestone Jul 16, 2021
@raix raix linked an issue Jul 16, 2021 that may be closed by this pull request
Webpack 5 support overview #9994
Closed
25 tasks
Morten N.O. Henriksen added 7 commits July 16, 2021 11:15
Bump @babel/eslint-parser to 7.14.7
b41322a
Fix missing @babel/eslint-parser dev dependency
0508303
ModuleScopePlugin ignore @babel/runtime/helpers/esm/assertThisInitial…
18045c0 
…ized

Would be great with wildcard support in ModuleScopePlugin
Move azurepipelines to ubuntu-latest
af889e1 
Warning: Ubuntu 16.04 LTS environment is deprecated and will be removed on September 20, 2021. Migrate to ubuntu-latest instead. For more details, see actions/runner-images#3287
Webpack config remove requireEnsure
2d3639c 
this should be the default already in webpack 5 - to enable require ensure use https://webpack.js.org/plugins/internal-plugins/#requireensureplugin
ModuleScopePlugin ignore @babel/runtime/regenerator
a7b4b6e
Update node-sass from v4 to v6 in fixtures
c3abea1 
On v4.14.1 linux tests failed: Node Sass does not yet support your current environment: Linux 64-bit with Unsupported runtime
@rawanst rawanst mentioned this pull request Sep 26, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 26, 2024
Open
@rawanst rawanst mentioned this pull request Sep 27, 2024
Open
@Hiranyape Hiranyape mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 27, 2024
Open
Open
@rawanst rawanst mentioned this pull request Sep 28, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 1, 2024
Merged
@rawanst rawanst mentioned this pull request Oct 1, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 1, 2024
Open
@rawanst rawanst mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 3, 2024
Open
@rawanst rawanst mentioned this pull request Oct 3, 2024
Open
@SanielDev SanielDev mentioned this pull request Oct 3, 2024
Open
@rawanst rawanst mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@SanielDev SanielDev mentioned this pull request Oct 6, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 15, 2024
Open
@Laurry-gee Laurry-gee mentioned this pull request Oct 21, 2024
Open
@nerds-github nerds-github mentioned this pull request Oct 23, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 28, 2024
Open
@rawanst rawanst mentioned this pull request Oct 29, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 31, 2024
Open
@barunslick barunslick mentioned this pull request Oct 31, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Nov 5, 2024
Open
@rawanst rawanst mentioned this pull request Nov 5, 2024
Open
@GregBrimble GregBrimble mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanisay27 emanisay27 emanisay27 left review comments

@sayedali2020 sayedali2020 sayedali2020 left review comments

@mwanagosos mwanagosos mwanagosos left review comments

@dawnofmidnight dawnofmidnight dawnofmidnight requested changes

@piotr-oles piotr-oles piotr-oles left review comments

@mrmckeb mrmckeb mrmckeb left review comments

@alexander-akait alexander-akait alexander-akait left review comments

@marella marella marella left review comments

@slorber slorber slorber left review comments

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

@elektronik2k5 elektronik2k5 elektronik2k5 approved these changes

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@petetnt petetnt Awaiting requested review from petetnt

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: breaking change tag: internal
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Webpack 5 support overview