Update Input Validation #1644
Update Input Validation #1644
Conversation
|
Hi @deannaflare! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| @@ -285,7 +285,7 @@ def exchange_create(): | |||
| api_type_name = data.get("api") | |||
|
|
|||
| if not re.match("^[A-Z0-9_]+$", bank): | |||
| abort(400, "Field `bank` must match /^[A-Z0-9_]$/") | |||
| abort(400, "Field `bank` must match /^[A-Z0-9_]+$/") | |||
There was a problem hiding this comment.
I think this was a typo? Updated it because the message doesn't match regex actually being called?
There was a problem hiding this comment.
Yup, typo. We can also explain it in english if that's easier.
| @@ -285,7 +285,7 @@ def exchange_create(): | |||
| api_type_name = data.get("api") | |||
|
|
|||
| if not re.match("^[A-Z0-9_]+$", bank): | |||
| abort(400, "Field `bank` must match /^[A-Z0-9_]$/") | |||
| abort(400, "Field `bank` must match /^[A-Z0-9_]+$/") | |||
There was a problem hiding this comment.
Yup, typo. We can also explain it in english if that's easier.
| <script> | ||
| document.getElementById('create_bank_bank_name').addEventListener('blur', function() { | ||
| const bankNameField = this; |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
This PR updates the input validations for the bank page and the exchanges page
The bank names should now auto format on blur.
Test Plan
Tested locally:
Bank Page:
Exchanges Page (create exchange form):
Screenshots