Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check dev mode functionality on page load #1643

Merged

Conversation

levi-cloudflare
Copy link
Contributor

Summary

This checks the status of the Sample API, Tx API, and bank seeding, and updates the dev mode buttons on the homepage if they already exist.

Screenshot 2024-10-03 at 11 50 29 AM
Screen.Recording.2024-10-03.at.11.53.06.AM.mov

Test Plan

  • Click "Sample API", verify the page reloads and the button is disabled and shows that the API already exists
  • Do the same with Tx API and "Seed Banks"
  • Click "Factory Reset" and verify the page reloads and buttons are usable again

@facebook-github-bot
Copy link
Contributor

Hi @levi-cloudflare!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz run black

@Dcallies Dcallies merged commit 849ffd2 into facebook:main Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants