Skip to content

Commit

Permalink
Do not discard previous data if ajax call fails
Browse files Browse the repository at this point in the history
  • Loading branch information
jonjlee committed Oct 15, 2010
1 parent 3606397 commit 8f08c66
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion TODO
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
- Interactive console for each node
- Edit test spec and "restart" (stop existing jobs / start updated test)
- Clean up removed nodes properly
- Download data as csv
- Unit testing with a framework
- Write a DEVELOPERS doc that explains the components
- Write a DEVELOPERS doc that explains the components
4 changes: 2 additions & 2 deletions console/js/console.data.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ function getTests(nodeId) {
}
function refreshReportsData(node) {
if (!node) return;
$.getJSON('http://' + node.name + '/data/', function(data) {
node.reports = data;
$.getJSON('http://' + node.name + '/data/', function(data, status) {
if (data) node.reports = data;
});
}

Expand Down
4 changes: 2 additions & 2 deletions console/js/console.ui.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ function resizeReportGraphs() {
}
}
function refreshReportGraphs(node) {
var reports = node.reports;
var summary = {}
var reports = node.reports,
summary = {};
for (var i in reports) {
// Add tabs for any new reports
var reportId = getIdFromString(i),
Expand Down

0 comments on commit 8f08c66

Please sign in to comment.