Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

feat(application): remove the application / environment widget from the dashboard #3469

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

joshuawilson
Copy link
Collaborator

@joshuawilson joshuawilson commented Jan 2, 2019

@centos-ci
Copy link
Collaborator

The E2E smoke test with feature level set to 'released' failed.

Link URL
job log https://ci.centos.org/job/devtools-fabric8-ui-e2e-smoketest-released/183/console
failure message http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-released/183/failures.txt
artifacts http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-released/183

Please review the job results and re-run the job by commenting [e2e-test-released] if necessary.

@centos-ci
Copy link
Collaborator

The E2E smoke test with feature level set to 'beta' failed.

Link URL
job log https://ci.centos.org/job/devtools-fabric8-ui-e2e-smoketest-beta/185/console
failure message http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-beta/185/failures.txt
artifacts http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-beta/185

Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary.

@alien-ike
Copy link
Collaborator

Ike Plugins (test-keeper)

Thank you @joshuawilson for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

@centos-ci
Copy link
Collaborator

The E2E smoke test with feature level set to 'beta' failed.

Link URL
job log https://ci.centos.org/job/devtools-fabric8-ui-e2e-smoketest-beta/186/console
failure message http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-beta/186/failures.txt
artifacts http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-beta/186

Please review the job results and re-run the job by commenting [e2e-test-beta] if necessary.

@centos-ci
Copy link
Collaborator

The E2E smoke test with feature level set to 'released' failed.

Link URL
job log https://ci.centos.org/job/devtools-fabric8-ui-e2e-smoketest-released/184/console
failure message http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-released/184/failures.txt
artifacts http://artifacts.ci.centos.org/devtools/e2e/devtools-fabric8-ui-e2e-smoketest-released/184

Please review the job results and re-run the job by commenting [e2e-test-released] if necessary.

@joshuawilson
Copy link
Collaborator Author

@ppitonak please check this against your test PR.

@ppitonak
Copy link
Contributor

ppitonak commented Jan 3, 2019

@joshuawilson we'll merge fabric8io/fabric8-test#1221 soon but checks for this PR will be still broken because of openshiftio/openshift.io#4670

@ljelinkova
Copy link
Collaborator

@joshuawilson Please do not merge this PR yet. We've realized that fabric8io/fabric8-test#1221 is not sufficient. It deletes all tests regarding deployments but that also means that the e2e tests would not test if the application is successfully deployed on stage and prod. We need to add that test first and then delete the old ones.

@ppitonak
Copy link
Contributor

ppitonak commented Jan 4, 2019

[e2e-test-released] [e2e-test-beta]

@ppitonak
Copy link
Contributor

ppitonak commented Jan 4, 2019

@joshuawilson feel free to merge when convenient

@joshuawilson
Copy link
Collaborator Author

/ok-without-tests

@alien-ike
Copy link
Collaborator

Hey @joshuawilson! It seems you tried to trigger /ok-without-tests command, but this will not have any effect due to insufficient permission. You have to be admin or requested reviewer or pull request approver, but not pull request creator for this command to take an effect.

@joshuawilson
Copy link
Collaborator Author

joshuawilson commented Jan 4, 2019

Look you dumb bot, I AM the admin and there are test updates. You should be green.

@joshuawilson
Copy link
Collaborator Author

[test]

@joshuawilson joshuawilson merged commit fe5d38e into fabric8-ui:master Jan 4, 2019
@joshuawilson joshuawilson deleted the deployments-clean-up branch January 4, 2019 18:50
@fabric8cd
Copy link
Contributor

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.