Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Use default failureThreshold value #2328

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jarifibrahim
Copy link
Member

@jarifibrahim jarifibrahim commented Oct 23, 2018

The fabric8-wit deployment to prod-preview was successful with #2327. We don't need failureThreshold:120 which is

Minimum consecutive failures for the probe to be considered failed after having succeeded

from https://docs.openshift.com/container-platform/3.5/rest_api/openshift_v1.html#v1-probe

This PR changes the failureThreshold value back to its default value which was changed in #2298 and #2295

Also see #2291

@jarifibrahim jarifibrahim self-assigned this Oct 23, 2018
@jarifibrahim jarifibrahim requested a review from kwk October 23, 2018 13:31
@alien-ike
Copy link

Ike Plugins (test-keeper)

Thank you @jarifibrahim for this contribution!

It appears that no tests have been added or updated in this PR.

Automated tests give us confidence in shipping reliable software. Please add some as part of this change.

If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.

For more information please head over to official documentation. You can find there how to configure the plugin.

@codecov
Copy link

codecov bot commented Oct 23, 2018

Codecov Report

Merging #2328 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
- Coverage   70.17%   70.15%   -0.02%     
==========================================
  Files         171      171              
  Lines       16625    16625              
==========================================
- Hits        11666    11664       -2     
- Misses       3829     3830       +1     
- Partials     1130     1131       +1
Impacted Files Coverage Δ
workitem/workitem_repository.go 67.79% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd8f88...314f456. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants