Merge pull request #155 from tisnik/fix-issue-150

Fixed issue #150
fabric8-analytics · Mar 20, 2019 · 97e573f · 97e573f
2 parents d3b2f28 + 42a8d60
commit 97e573f
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/tests/files/npm-list-transitive-dependencies.json b/tests/files/npm-list-transitive-dependencies.json
@@ -0,0 +1,21 @@
+{
+    "dependencies": {
+        "body-parser": {
+            "version": "1.18.2",
+            "dependencies": {
+                "debug": {
+                    "version": "2.6.9",
+                    "from": "[email protected]",
+                    "resolved": "https://registry.npmjs.org/debug/-/debug-2.6.9.tgz",
+                    "dependencies": {
+                        "ms": {
+                            "version": "2.0.0",
+                            "from": "[email protected]",
+                            "resolved": "https://registry.npmjs.org/ms/-/ms-2.0.0.tgz"
+                        }
+                    }
+                }
+            }
+        }
+    }
+}
diff --git a/tests/test_node_parser.py b/tests/test_node_parser.py
@@ -22,6 +22,10 @@ def test_node_parser():
     with (Path(__file__).parent / "files/npm-list.json").open('rb') as f:
         direct_dependencies, transitive_dependencies = \
             NodeParser.parse_output_files([FileStorage(f)])
+
+        assert direct_dependencies is not None
+        assert transitive_dependencies is not None
+
         assert direct_dependencies == {
             "npm:github-url-to-object:4.0.4",
             "npm:lodash:4.17.10",
@@ -33,3 +37,20 @@ def test_node_parser():
             "npm:is-url:1.2.4",
             "npm:semver:5.5.1"
         }
+
+
+def test_node_parser_transitive_dependencies():
+    """Test node parser for transitive dependencies."""
+    with (Path(__file__).parent / "files/npm-list-transitive-dependencies.json").open('rb') as f:
+        direct_dependencies, transitive_dependencies = \
+            NodeParser.parse_output_files([FileStorage(f)])
+
+        assert direct_dependencies is not None
+        assert transitive_dependencies is not None
+
+        assert direct_dependencies == {
+            "npm:body-parser:1.18.2"
+        }
+        assert transitive_dependencies == {
+            "npm:ms:2.0.0"
+        }