Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove make #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove make #7

wants to merge 1 commit into from

Conversation

abs51295
Copy link
Contributor

No description provided.

@abs51295 abs51295 self-assigned this May 16, 2018
@abs51295 abs51295 requested a review from rootAvish May 16, 2018 14:37
@centos-ci
Copy link
Collaborator

@abs51295 Your image is available in the registry: docker pull registry.devshift.net/fabric8-analytics/f8a-kronos-base:SNAPSHOT-PR-7

@rootAvish
Copy link
Contributor

I'm okay with keeping make as a dependency, there might be something else in the future it's required with and it takes up minimal space inside the image.

rootAvish
rootAvish approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@rootAvish rootAvish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you still want to remove it, I'm okay with that too.

@abs51295
Copy link
Contributor Author

Umm, let's remove it as of now, we will add it again in future if the need arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootAvish rootAvish rootAvish approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@abs51295 abs51295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abs51295 @centos-ci @rootAvish