LLVM 18 #123
Merged
LLVM 18 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
llvm-17
branch
from
a49f5f9
to
b226612
Compare
csegarragonz
force-pushed
the
llvm-17
branch
from
b226612
to
2aa9661
Compare
csegarragonz
force-pushed
the
llvm-17
branch
from
c27bb35
to
53f6567
Compare
csegarragonz
force-pushed
the
llvm-17
branch
from
38684f4
to
29403d4
Compare
csegarragonz
force-pushed
the
llvm-17
branch
from
160824f
to
0b67978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we move the WASM LLVM version to 18 and the native one to 17.
As much as it hurts, recent changes in
wasi-libcdrop support for LLVM < 15. This means that we cannot keep up to date with upstreamwasi-libc, which is necessary for an integrity issue that I am seeing with OpenMP execution.In summary, I would like to re-build
wasi-libcwithatomics(and shared memory) support.I could either patch this on top of our current version of
wasi-libc, or rebase to the latest commit, and build from there.The former sounds appealing, but I think the latter is the safest strategy long-term.
In addition, it more and more seems that re-entrant WASM modules (i.e. WASM modules that will be concurrently operated on by different threads) and non-re-entrant WASM modules have incompatible toolchains.
To this extent, I change our sysroot structure to match more that of
wasi-sdk. Now, we support having different targets for different WASM features (that are incompatible with each other).This also deems obsolete the old
THREAD_MODEL=faasmthat we used to have, allowing to have co-existing purely non-reentrant sysroot and a re-entrant one.In this PR we have:
/usr/local/faasm/llvm-sysroot/{include,lib}/wasm32-wasi: for non-atomic, non-threaded code./usr/local/faasm/llvm-sysroot/{include,lib}/wasm32-wasi-threads: for atomic WASM.Note that, in the latter, we still disable native WASM threads by carefully linking with out own
pthreadimplementation rather thanwasi-libcs.This should also greatly simplify our diff with upstream
wasi-libc.