Skip to content

Commit

Permalink
faasmtools: pass relaxed-simd compilation flag (#124)
Browse files Browse the repository at this point in the history
* faasmtools: pass -mrelaxed-simd flag

* gh: bump code version

* gha: credential-less access

* faasmtools: clean-up comment
  • Loading branch information
csegarragonz authored Mar 18, 2024
1 parent d9fc3ac commit 23da49b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .env
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
SYSROOT_VERSION=0.4.0
SYSROOT_CLI_IMAGE=faasm.azurecr.io/cpp-sysroot:0.4.0
SYSROOT_VERSION=0.5.0
SYSROOT_CLI_IMAGE=faasm.azurecr.io/cpp-sysroot:0.5.0
COMPOSE_PROJECT_NAME=cpp-dev
5 changes: 1 addition & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@ jobs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
container:
image: faasm.azurecr.io/cpp-sysroot:0.4.0
credentials:
username: ${{ secrets.ACR_SERVICE_PRINCIPAL_ID }}
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
image: faasm.azurecr.io/cpp-sysroot:0.5.0
steps:
# --- Update code ---
- name: "Checkout code"
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ a.out

# Distribution / packaging
.Python
build/
build*/
develop-eggs/
dist/
downloads/
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.4.0
0.5.0
4 changes: 3 additions & 1 deletion faasmtools/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
# https://reviews.llvm.org/D59281
WASM_CFLAGS = [
"-O3",
# TODO: may want to use -mrelaxed-simd instead
"-mrelaxed-simd",
"-msimd128",
"--sysroot={}".format(WASM_SYSROOT),
"-m32",
Expand Down Expand Up @@ -242,6 +242,7 @@ def get_faasm_build_env_dict(is_threads=False):
"atomics",
"bulk-memory",
"mutable-globals",
"relaxed-simd",
"sign-ext",
"simd128",
]
Expand All @@ -251,6 +252,7 @@ def get_faasm_build_env_dict(is_threads=False):
linker_features = [
"bulk-memory",
"mutable-globals",
"relaxed-simd",
"sign-ext",
"simd128",
]
Expand Down

0 comments on commit 23da49b

Please sign in to comment.