Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address change in console instance deletion behavior #34

Merged
merged 1 commit into from
Nov 6, 2024
Merged

address change in console instance deletion behavior #34

merged 1 commit into from
Nov 6, 2024

Conversation

aknot242
Copy link
Collaborator

@aknot242 aknot242 commented Nov 6, 2024

Instances in a config sync group now require stopping before deletion is allowed.

Addresses #33

@aknot242 aknot242 requested a review from codygreen November 6, 2024 14:33
@aknot242 aknot242 self-assigned this Nov 6, 2024
@aknot242 aknot242 requested a review from gdmoore85 November 6, 2024 14:33
gdmoore85
gdmoore85 approved these changes Nov 6, 2024
View reviewed changes
Copy link

@gdmoore85 gdmoore85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!

@aknot242 aknot242 merged commit d43337e into main Nov 6, 2024
@aknot242 aknot242 deleted the issue-33 branch November 6, 2024 17:25
@aknot242 aknot242 restored the issue-33 branch November 6, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdmoore85 gdmoore85 gdmoore85 approved these changes

@codygreen codygreen Awaiting requested review from codygreen

Assignees

@aknot242 aknot242

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknot242 @gdmoore85