Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2159 #2238

Merged
merged 16 commits into from
Aug 27, 2024
Merged

Fix 2159 #2238

merged 16 commits into from
Aug 27, 2024

Conversation

f4exb
Copy link
Owner

@f4exb f4exb commented Aug 21, 2024

Changes to make the device engines really asynchronous. Partially solving #2159.

@f4exb
Removed SyncMessenger from DSPDeviceSourceEngine. Part of #2159
4a6943b
@f4exb
Fixed threading model for DSPDeviceSourceEngine. Part of #2159
580fbda
@f4exb
Removed SyncMessenger from DSPDeviceMIMOEngine. Part of #2159
0ff75e1
@f4exb
RTLSDR: make sure start and stop are effective once only. PArt of #2159
f5e7708
@f4exb
Fixed threading model for DSPDeviceMIMOEngine plus other fixes. Part of
436d166 
#2159
@f4exb
NFMMod: revised thread processing
4a2032a
@f4exb
AMMod: revised thread processing
7739dfd
@f4exb
Removed SyncMessenger from DSPDeviceSinkEngine. Part of #2159
7d1af5b
@f4exb
SSBMod: revised thread processing
0208d11
@f4exb
Fixed threading model for DSPDeviceSinkEngine plus other fixes. Part of
24dba6f 
#2159
@f4exb
DeviceSet and DeviceUISet: use delete channel API instead of destroy …
49074d1 
…method so that the virtual destructor of the channel is called appropriately
@f4exb
BladeRF2Output: removed applySettings from stop method
38043eb
@f4exb
All device plugins: make sure start and stop are effective once only.…
3a7de65 
… PArt of #2159
@f4exb
Sonar fixes
36349e2
@f4exb
Removed the destroy method from ChannelGUI interface
a014491
@f4exb
Removed destroy method leftovers and Sonar lint
b3215ce
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 25, 2024 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
13.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@f4exb f4exb marked this pull request as ready for review August 27, 2024 01:22
@f4exb f4exb merged commit 5d0fa7f into master Aug 27, 2024
3 of 5 checks passed
@f4exb f4exb deleted the fix-2159 branch August 27, 2024 07:54
@f4exb
Copy link
Owner Author

f4exb commented Aug 28, 2024

Well I think at least sometimes the sample source is not stopped and disposed properly:

2024-08-28 09:41:25.273 (D) MainWindow::removeLastDeviceSet: RTLSDR
2024-08-28 09:41:25.273 (D) DSPDeviceSourceEngine::removeSink:  SpectrumVis
2024-08-28 09:41:25.273 (D) DeviceUISet::freeChannels: destroying channel [sdrangel.channel.wdsprx]
2024-08-28 09:41:25.273 (D) DSPDeviceSourceEngine::handleInputMessages: message: DSPRemoveBasebandSampleSink
2024-08-28 09:41:25.273 (D) ChannelGUI::~ChannelGUI
2024-08-28 09:41:25.274 (D) ChannelGUI::~ChannelGUI: end
2024-08-28 09:41:25.276 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.277 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.278 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.278 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.278 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.279 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.280 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.280 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.281 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.281 (W) QOpenGLTexturePrivate::destroy() called without a current context.
Texture has not been destroyed
2024-08-28 09:41:25.284 (D) DSPDeviceSourceEngine::removeSink:  WDSPRx
2024-08-28 09:41:25.284 (D) WDSPRx::stop
2024-08-28 09:41:25.284 (D) AudioDeviceManager::removeAudioSink: 0x7f69fc034590
2024-08-28 09:41:25.284 (D) DSPDeviceSourceEngine::handleInputMessages: message: DSPRemoveBasebandSampleSink
2024-08-28 09:41:25.284 (D) FFTFactory::releaseEngine: engineSequence: 2 FFT fwd size: 1024
2024-08-28 09:41:25.284 (D) DeviceUISet::freeChannels: destroying channel [sdrangel.channel.dsddemod]
2024-08-28 09:41:25.285 (D) ChannelGUI::~ChannelGUI
2024-08-28 09:41:25.285 (D) ChannelGUI::~ChannelGUI: end
2024-08-28 09:41:25.285 (D) DSPDeviceSourceEngine::removeSink:  DSDDemod
2024-08-28 09:41:25.285 (D) DSDDemod::stop
2024-08-28 09:41:25.285 (D) DSPDeviceSourceEngine::handleInputMessages: message: DSPRemoveBasebandSampleSink
2024-08-28 09:41:25.285 (D) AudioDeviceManager::removeAudioSink: 0x55c797f0c970
2024-08-28 09:41:25.285 (D) AudioDeviceManager::removeAudioSink: 0x55c797f0c9b0
2024-08-28 09:41:25.285 (D) AudioOutputDevice::stop: thread: 0x55c7980ab830
2024-08-28 09:41:25.286 (D) RTLSDRGui::~RTLSDRGui
2024-08-28 09:41:25.286 (D) 2024-08-28 09:41:25.286 (D) DeviceGUI::~DeviceGUI
2024-08-28 09:41:25.286 (D) DeviceGUI::~DeviceGUI: end
2024-08-28 09:41:27.287 (C) SampleSinkFifo::write: (RTLSDR) overflow - dropping 1024 samples
2024-08-28 09:41:29.788 (C) SampleSinkFifo::write: (RTLSDR) 468 messages dropped
2024-08-28 09:41:29.788 (C) SampleSinkFifo::write: (RTLSDR) overflow - dropping 1024 samples
2024-08-28 09:41:29.793 (C) SampleSinkFifo::write: (RTLSDR) overflow - dropping 1024 samples
2024-08-28 09:41:32.295 (C) SampleSinkFifo::write: (RTLSDR) 468 messages dropped
2024-08-28 09:41:32.295 (C) SampleSinkFifo::write: (RTLSDR) overflow - dropping 1024 samples
2024-08-28 09:41:32.300 (C) SampleSinkFifo::write: (RTLSDR) overflow - dropping 1024 samples
2024-08-28 09:41:34.801 (C) SampleSinkFifo::write: (RTLSDR) 468 messages dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@f4exb