Fix build failure when Qt Location is not available #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds parenthesis to fix the precedence in the existing test and adds another condition that makes the presence of Qt Location actually optional like in the top level CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Qt Location is not available, cmake prints
(I'm using Debian testing and at this time in not yet available for Qt 6, it's available in experimental.
The existing test was wrong in the part that checked for WebEngine/WebEngineCore the because precedence is from left to right (https://cmake.org/cmake/help/latest/command/if.html#and) and it didn't check for Qt Location.
In the top level CMakeLists.txt Qt Location is optional.