DSD Demod - Fix loss of constellation #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added another patch, so that the AudioSelectDialog uses the DialogPositioner so that it is fully visible on screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSD Demod constellation will not appear if !m_running when GUI is created or if acquisition is restarted (which recreates the baseband object).
This patch fixes this, by saving a pointer to m_scopeXYSink in DSDDemod, so that it can be used to initialise the baseband/sink every time it is created.
Also, this patch adds a warning in the DSDDemod GUI if the sample rate is < 48kHz.
For #1836