Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo URL improvements #138

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sgvictorino
Copy link

@sgvictorino sgvictorino commented Aug 1, 2024

No description provided.

@sgvictorino sgvictorino force-pushed the forge-url-improvements branch 3 times, most recently from 4b12cde to 19e3677 Compare August 2, 2024 01:01
@sgvictorino sgvictorino marked this pull request as ready for review August 2, 2024 01:02
@sgvictorino sgvictorino force-pushed the forge-url-improvements branch 2 times, most recently from 7cd697f to 84f4a1b Compare August 5, 2024 02:20
@sgvictorino sgvictorino force-pushed the forge-url-improvements branch from 84f4a1b to 0320bd8 Compare October 20, 2024 22:15
Copy link
Collaborator

@bossley9 bossley9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't review this earlier 😅 looks pretty good! Just left some comments

lua/gitblame/config.lua Show resolved Hide resolved
lua/gitblame/git.lua Show resolved Hide resolved
@sgvictorino sgvictorino force-pushed the forge-url-improvements branch from 0320bd8 to 3c5c381 Compare October 31, 2024 16:39
@sgvictorino sgvictorino force-pushed the forge-url-improvements branch 2 times, most recently from c298680 to d8a8630 Compare October 31, 2024 20:58
Copy link
Collaborator

@bossley9 bossley9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this!

@bossley9 bossley9 requested a review from f-person November 1, 2024 14:26
options in vim global variables no longer override:

- nested keys in `default_opts`
- `setup` `opts` with default-equivalent values
@sgvictorino sgvictorino force-pushed the forge-url-improvements branch from d8a8630 to 27806a3 Compare November 1, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants