Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

대여기능 초기 세팅 #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ingyeomnote
Copy link
Collaborator

📗요약

대여기능에 필요한 설정 파일들을 초기 구성했습니다.

🛠️작업 사항

  1. AppConfig 생성
  2. JspServlet 의존성 제거
  3. Rental Dto, Entity 생성
  4. MyWebAppInitializer 제거
  5. EmbeddedTomcatApplication 수정

🗨️공유사항 to 리뷰어

조인을 사용하지 않고 대여기능을 구성하기 위해 Rental Entity를 구성했습니다.

@ingyeomnote ingyeomnote self-assigned this Nov 28, 2024
src/main/java/com/wheelgo/config/ServletAppContext.java Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@@ -11,9 +16,24 @@ public static void main(String[] args) {
Tomcat tomcat = new Tomcat();
tomcat.setPort(8080);

// webapp 디렉터리 설정
// 빈 컨텍스트 생성
String webappDir = new File("src/main/webapp").getAbsolutePath();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재, 정적 리소스를 사용하지 않으므로 불필요합니다.

appContext.setServletContext(context.getServletContext());

// 애플리케이션 컨텍스트 초기화
appContext.refresh();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서 명시적으로 호출하는 이유가 있나요?

Copy link

@roam-f-lab roam-f-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log 의존성을 추가하고 println을 제거해주세요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants