[#1] 스플래시 화면 작성 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*change launch activity
f-lab-Toru
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
영문 string이 없으면 아마도 안드로이드스튜디오에서 경고를 보낼 거 같은데 영문추가도 고려해 보시면 좋을 것 같아요.
|
|
||
| class SplashActivity : ComponentActivity() { | ||
|
|
||
| private val locationPermissionLauncher = registerForActivityResult( |
There was a problem hiding this comment.
Permission grant 요청하는 부분을 액티비티에 넣는것보다는 뷰모델이나 다른 클래스에서 하는게 좀더 코드의 책임 측면에서 좋을 것 같은데 한번 리서치를 해보면 좋을거 같아요.
There was a problem hiding this comment.
네 알겠습니다. ViewModel을 만들지 말지 고민하다가 만들지 않았는데... Splash 화면에서 해야할 것들이 좀 더 있을거같아 만드는게 나을거같습니다. 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
멘토님께