feat:AES 암호화 방식 유틸리티 추가#15 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-jd
reviewed
Nov 9, 2024
| @Slf4j 애노테이션을 클래스에 붙이면 자동으로 log 객체를 생성합니다. | ||
| log 객체를 직접 생성하지 않고 log 메서드를 사용할 수 있습니다. | ||
| */ | ||
| @Slf4j |
There was a problem hiding this comment.
해당 어노테이션의 동작방식에 대해서도 적어주시면 더 좋을 것 같습니다.
| private static final String ALGORITHM = "AES/CBC/PKCS5Padding"; | ||
| /** | ||
| * TODO | ||
| * 패스워드와 salt를 어떻게 보관할 것인지 고민입니다. |
There was a problem hiding this comment.
password 와 salt 의 차이는 무엇인가요? application.yml 에 보관하는 것은 어떨까요?
There was a problem hiding this comment.
password는 암호화 및 복호화를 위해 필요한 key입니다
동일한 key를 가지고 만든 암호화 데이터는 모두 같은 key를 통해 복호화가 가능하므로 보안상 위험합니다.
따라서 password에 salt의 임의의 값을 추가하여 암호화를 하는 경우에는 암호화 결과가 다르게 나오게 됩니다.
현재 로직에서는 고정된 salt를 사용하여 salt를 사용하는 의미가 없어졌습니다.
| } | ||
|
|
||
| private static IvParameterSpec generateIv() { | ||
| byte[] iv = new byte[16]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝작업 내용
✒️ 코드 변경 이유
💬리뷰 요구사항(선택)
객체지향 체조 3가지 확인📌