[#16] 로그인 기능 테스트 코드 작성 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. LoginRequestEntity 추가 2. LoginRequestEntity로 파라미터 변경 3. LoginRequestEntity를 위한 Converter 추가
1. Bloc이 위젯에 변화에 따라 실제 로직 테스트가 안되고 있는 상황이라 해결 방법 고민 중
1. Router 테스트 가능하게 주입 방식으로 변경
1. LoginBloc의 경우 싱글톤이 아닌 팩토리로 등록하기 때문에 getIt으로 조회하면 각각의 인스턴스로 취급되는 것 같음
abdul0986
reviewed
Nov 11, 2024
abdul0986
reviewed
Nov 11, 2024
1. 복잡한 & 조건문을 hasFailMessage로 변경 2. 코드에서 정확한 의도를 반영할 수 있게 변경
Younggun-Kim
commented
Nov 12, 2024
| @@ -48,8 +48,7 @@ class _LoginPageState extends State<LoginPageContent> { | |||
| getItAppRouter.replaceAll([const JobPostingsRoute()]); | |||
| } | |||
|
|
|||
| /// 로그인 실패 | |||
| if (state.status.isFailure && state.message.isNotEmpty) { | |||
| if (state.hasFailMessage) { | |||
| await CustomAlertDialog.showContentAlert( | |||
| context: context, | |||
| content: state.message, | |||
There was a problem hiding this comment.
복잡한 & 조건문 대신
hasFailMessage 를 통해
더 명확한 의도를 전달할 수 있게 변경했습니다.
|
요거 머지해주세요~!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 사항
AccountApiImpl에서Dio객체를 의존성 주입받도록 변경테스트 케이스
[#16 ] 이슈에 정리해 두었습니다.