[6] 일반 회원, 파트너 생성 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mason136
reviewed
Aug 28, 2024
| import org.example.commerce_site.attribute.PartnerStatus; | ||
| import org.example.commerce_site.domain.Partner; | ||
|
|
||
| public class PartnerRequestDTO { |
| private final UserService userService; | ||
|
|
||
| public UserResponseDTO.Create create(UserRequestDTO.Create dto) { | ||
| return userService.create(dto); |
There was a problem hiding this comment.
Facade는 필요할 때만 쓰셔도 됩니다
지금처럼 by-pass 할 떄는 굳이 안쓰셔도 되요
There was a problem hiding this comment.
나중에 필요할거 같아서 미리 추가하긴 했는데 일단 지금은 지우고 필요하면 그때 다시 리팩토링 하는게 나은가요?
| public abstract class BaseTimeEntity extends IdKeyEntity { | ||
| @CreatedDate | ||
| @Column(name = "created_at") | ||
| protected Instant createdAt; |
There was a problem hiding this comment.
LocalDateTime으로 저장해야 사람이 이해하기 쉽지 않을까요?
|
|
||
| @Getter | ||
| @MappedSuperclass | ||
| @SuperBuilder |
There was a problem hiding this comment.
createdAt, updatedAt를 하위 클래스 생성할 때 쓸일이 있을까요? 없으면 굳이 기본으로 안넣으셔도 됩니다.
There was a problem hiding this comment.
언제 생성, 수정되었는지 보여줘야 할 필요가 있을것같아서 엔티티 마다 created_at updated_at 을 넣었습니다
There was a problem hiding this comment.
SuperBuilder를 안 써도 created_at updated_at를 만들 수 있어서 SuperBuilder가 필요 없으면 제거하셔도 된다는 말씀이였어요!
- DTO -> Dto - Instant -> LocalDateTime - Facade 제거
mason136
approved these changes
Aug 30, 2024
|
|
||
| @Getter | ||
| @MappedSuperclass | ||
| @SuperBuilder |
There was a problem hiding this comment.
SuperBuilder를 안 써도 created_at updated_at를 만들 수 있어서 SuperBuilder가 필요 없으면 제거하셔도 된다는 말씀이였어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.