[15] 사용자 리뷰 남기기 #53
Open
[15] 사용자 리뷰 남기기 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
f-lab-kai-c
reviewed
Nov 5, 2024
| @@ -98,4 +98,10 @@ public GroupedOpenApi shipmentsOpenApi() { | |||
| String[] paths = {"/shipments/**"}; | |||
| return GroupedOpenApi.builder().group("SHIPMENT API").pathsToMatch(paths).build(); | |||
| } | |||
|
|
|||
| @Bean | |||
| public GroupedOpenApi reviewsOpenApi() { | |||
There was a problem hiding this comment.
url이 추가될때마다 매번 관리하는건 번거로운 일인데 매번 추가하지 않고 관리할 수 있는 방법은 없을까요?
There was a problem hiding this comment.
representation 하위에 있는 패키지의 controller 들을 자동으로 등록하는 방식으로 수정했습니다!
f-lab-kai-c
reviewed
Nov 23, 2024
| String[] paths = {"/orders/**"}; | ||
| return GroupedOpenApi.builder().group("ORDER API").pathsToMatch(paths).build(); | ||
| } | ||
| private Set<String> findSubPackages(String basePackage) { |
There was a problem hiding this comment.
함수의 이름이 적절할지 한번더 고민해보시면 좋을 것 같습니다.
Comment on lines
55
to
61
| public GroupedOpenApi partnerOpenApi() { | ||
| String[] paths = {"/partners/**"}; | ||
| return GroupedOpenApi.builder().group("PARTNER API").pathsToMatch(paths).build(); | ||
| } | ||
| Set<String> subPackages = findSubPackages(BASE_PACKAGE); | ||
|
|
||
| @Bean | ||
| public GroupedOpenApi productOpenApi() { | ||
| String[] paths = {"/products/**"}; | ||
| return GroupedOpenApi.builder().group("PRODUCT API").pathsToMatch(paths).build(); | ||
| } | ||
| for (String pkg : subPackages) { | ||
| String groupName = pkg.substring(pkg.lastIndexOf('.') + 1).toUpperCase() + " API"; |
There was a problem hiding this comment.
sub package를 구하고 등록하는 형태가 불안정한 것 같아요. package 네이밍 규칙 변경 등, 여러 요소에 따라 깨지기 쉬운 것 같은데, 이를 좀 더 안정적으로 관리할 수 있는 방법은 없을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.