[43] AOP 를 사용한 권한 체크 #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
f-lab-kai-c
reviewed
Oct 20, 2024
|
|
||
| private static final String AUTHORIZATION = "Authorization"; | ||
| private static final String BEARER_PREFIX = "Bearer "; | ||
| private final HttpServletRequest httpServletRequest; |
There was a problem hiding this comment.
클라이언트가 서버에 요청을 보내면 tomcat 이 이를 수신하고 디스패쳐 서블릿으로 보냅니다.
디스패쳐 서블릿은 모든 http 요청을 가로채서 요청이 처리 되는 동안에 유효한 HttpServletRequest 객체를 만들고 스프링에서 이를 주입해줍니다.
| return jwtDecoder.decode(token); | ||
| } catch (JwtException e) { | ||
| log.error(e.getMessage()); | ||
| throw new JwtException(e.getMessage()); |
There was a problem hiding this comment.
이 에러가 발생하면 사용자한테는 어떤 에러 코드가 전달되나요?
There was a problem hiding this comment.
헉 커스텀 예외처리해 500이 뜨도록 수정했습니다
There was a problem hiding this comment.
500은 서버가 에러난 상황인데, 지금은 어떤 에러코드가 좋을지 한번더 고민해보면 좋을 것 같습니다.
There was a problem hiding this comment.
jwt 디코딩은 인증과 관련된 문제이므로 401 이 더 알맞을 것 같네요
f-lab-kai-c
reviewed
Oct 24, 2024
| @@ -16,6 +16,9 @@ public enum ErrorCode { | |||
| INVALID_PARAM(HttpStatus.BAD_REQUEST, 400, "잘못된 parameter 입니다."), | |||
| ACCESS_DENIED(HttpStatus.FORBIDDEN, 403, "권한이 부족합니다."), | |||
| METHOD_NOT_ALLOWED(HttpStatus.METHOD_NOT_ALLOWED, 405, "허용되지 않은 메소드 입니다."), | |||
| //auth | |||
| JWT_DECODING_ERROR(HttpStatus.NOT_FOUND, 500, "JWT Decoding error"), | |||
f-lab-kai-c
reviewed
Oct 26, 2024
| @@ -17,7 +17,7 @@ public enum ErrorCode { | |||
| ACCESS_DENIED(HttpStatus.FORBIDDEN, 403, "권한이 부족합니다."), | |||
| METHOD_NOT_ALLOWED(HttpStatus.METHOD_NOT_ALLOWED, 405, "허용되지 않은 메소드 입니다."), | |||
| //auth | |||
| JWT_DECODING_ERROR(HttpStatus.NOT_FOUND, 500, "JWT Decoding error"), | |||
| JWT_DECODING_ERROR(HttpStatus.NOT_FOUND, 401, "JWT Decoding error"), | |||
There was a problem hiding this comment.
httpStatus도 맞추면 좋을 것 같습니다. HttpStatus와 code를 각각 받아야할까요?
f-lab-kai-c
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserCheck, PartnerCheck 어노테이션을 만들어서, 어노테이션이 적용된 메서드에 토큰 권한을 체크하는 로직을 AOP로 만들었습니다.