[39] 주문 전 재고 체크 및 재고 감소 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-kai-c
reviewed
Oct 17, 2024
| @Repository | ||
| public interface ProductRepository extends JpaRepository<Product, Long> { | ||
| @Lock(LockModeType.PESSIMISTIC_WRITE) | ||
| @Query("SELECT p FROM Product p WHERE p.id IN :productIds") | ||
| List<Product> findByIdIn(List<Long> productIds); |
There was a problem hiding this comment.
Lock을 잡는 쿼리와 아닌 쿼리는 메소드 레벨에서 구분하는게 좋습니다. 의도치 않게 lock을 잡는 실수를 방지할 수 있습니다.
There was a problem hiding this comment.
findByIdInWithLock 으로 메소드 이름을 변경했습니다..!
| .map(OrderRequestDto.CreateDetail::getProductId) | ||
| .toList(); | ||
|
|
||
| List<Product> products = productRepository.findByIdIn(productIds); |
There was a problem hiding this comment.
트랜잭션어노테이션으로 지정한 부분이 종료 될때까지 유효한걸로 알고 있습니다!
f-lab-kai-c
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.